[Bug 1601186] Review Request: wpewebkit - A WebKit port optimized for low-end devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1601186



--- Comment #4 from Michael Catanzaro <mcatanzaro@xxxxxxxxx> ---
(In reply to Chris King from comment #3)
> That is something I've been wondering about, the minibrowser isn't even in
> the install files, despite my building with the cmake flage of
> ENABLE_MINIBROWSER=ON. I don't know as much about the inner workings of
> webkit/WPE as you probably do, so help on this would be great. 

Hmm, the MiniBrowser was added after 2.20, so you'll have to package a newer
tarball. 2.20 is the latest stable version (appropriate for F28), but you
probably want the latest unstable for rawhide, which will have MiniBrowser.

> I have packaged wpebackend-fdo 0.1 in my copr repository, I can also make a
> package review request for that if you think that'll be necessary.

It's definitely necessary, or it won't be able to run at all.

> > -DCMAKE_EXE_LINKER_FLAGS="${CMAKE_EXE_LINKER_FLAGS} -lrt" should indeed not
> > be needed, would be good to add a FIXME to figure out how to remove that.
> 
> Trying to build without this fails in copr, so I guess it's not just my
> machine, what is the process for adding a FIXME?

Just add a comment in the spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/I4B7TB3MIWYWJBUAQ2NTVDRTHY36IIN6/




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux