https://bugzilla.redhat.com/show_bug.cgi?id=1601186 Michael Catanzaro <mcatanzaro@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mcatanzaro@xxxxxxxxx --- Comment #1 from Michael Catanzaro <mcatanzaro@xxxxxxxxx> --- Were you able to successfully run the minibrowser? It cannot work unless you additionally package a WPE backend (e.g. WPEBackend-fdo). (In reply to Chris King from comment #0) > 2.) I am unsure if some of the patches included in the webkit2gtk3 package > that I based this spec file off of > (https://src.fedoraproject.org/rpms/webkit2gtk3/blob/master/f/webkit2gtk3. > spec) were needed for this package, nor how to go about adding those should > they be necessary as they were all made for webkit2gtk3. I have an inkling > that some of them, specifically the fedora-crypto-policy and python2 patch > are necessary. We'll need to duplicate the fedora-crypto patch in both packages forever, yes. User agent patch is optional. The python patch should only be needed to avoid a build failure, so if it builds successfully on rawhide without it, then it should probably be dropped. The other patches should really go upstream, so we can drop them. I managed to upstream the page size patch recently. The big endian patch is harder. > 3.) Finally, to make the package build on my machine I had to add a cmake > option on line 102 of the spec that I feel is probably not ideal, so any > advice on that would be welcome. -DCMAKE_EXE_LINKER_FLAGS="${CMAKE_EXE_LINKER_FLAGS} -lrt" should indeed not be needed, would be good to add a FIXME to figure out how to remove that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/HDAMDPAHAAR6ZT3N4OIZXSCQXFMGHF6U/
