https://bugzilla.redhat.com/show_bug.cgi?id=1601058 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - The license shorthand is wrong, see the list here: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses License: BSD-2-Clause - Use a more meaningful name for your archive with: Source0: https://github.com/WebPlatformForEmbedded/WPEBackend/archive/%{version}/%{name}-%{version}.tar.gz - make %{?_smp_mflags} → %make build - you must install the license file in %files: %files %license COPYING %doc NEWS - the packaging should include a devel subpackage to contain the development files. Read https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages %package devel Summary: Development files for WPE-backend Requires: %{name}%{?_isa} = %{version}-%{release} %description devel Development files for WPE-backend, a general-purpose library specifically developed for the WPE-flavored port of WebKit. And: %files %license COPYING %doc NEWS %{_libdir}/libWPEBackend-0.1.so.0 %{_libdir}/libWPEBackend-0.1.so.0.2.0 %files devel %{_includedir}/wpe-0.1/wpe/input.h %{_includedir}/wpe-0.1/wpe/loader.h %{_includedir}/wpe-0.1/wpe/pasteboard.h %{_includedir}/wpe-0.1/wpe/renderer-backend-egl.h %{_includedir}/wpe-0.1/wpe/renderer-host.h %{_includedir}/wpe-0.1/wpe/version.h %{_includedir}/wpe-0.1/wpe/view-backend.h %{_includedir}/wpe-0.1/wpe/wpe-egl.h %{_includedir}/wpe-0.1/wpe/wpe.h %{_libdir}/libWPEBackend-0.1.so %{_libdir}/pkgconfig/wpe-0.1.pc - The long list of BR is very dubious, from what I gather on the Github repo you only need pkgconfig(egl), cmake and gcc-c++ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/UO6GNSBATWCMFTZPM66BWZPYICYZURYD/
