https://bugzilla.redhat.com/show_bug.cgi?id=1599666 --- Comment #2 from Kairui Song <kasong@xxxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #1) Thanks you very much for the review! > - When packaging a dev snapshot, you should also add the snapshot date to > the Release tag: > > %global gitcommit 8b243e38737fdd0f1e2d5f67445b8980e11d854c > %global gitshortcommit %(c=%{gitcommit}; echo ${c:0:7}) > %global snapshotdate 20180710 > > > Release: 1.%{snapshotdate}git%{gitshortcommit}%{?dist} Yes, I thought there were already version number and release number so dropped the snapshot date. Will update the spec file. > > - Group: us not used in Fedora > > - You're missing the URL: field: > > URL: https://github.com/daveyoung/kdump-anaconda-addon > > - Why did you add this Obsoletes: > > Obsoletes: kdump-anaconda-addon <= 2.0.17-3 > > We do not have a kdump-anaconda-addon package to obsolete on Fedora. The > package in kexec-tools is called "anaconda-addon" Maybe it's this one you > need to Obsoletes? But in this case, youl also need to add a Provides: Oops, the package I want to obsoletes is kexec-tools-anaconda-addon, will fix it. > > - DESTDIR=%{buildroot} make install → %make_install > > - You must install the LICENSE file in %files with %license and should > install the READNE with %doc > > %files -f kdump-anaconda-addon.lang > %doc README > %license LICENSE > > - The changelog entry should contain the version-release info: > > * Mon Jul 9 2018 Kairui Song <kasong@xxxxxxxxxx> - 005-1.20180710git8b243e3 Will update the spec to fix those issues. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/WIP324OVJRJ7VTW6AZK3GZPWMEEJI3HZ/
