https://bugzilla.redhat.com/show_bug.cgi?id=1585758 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - This is not needed even in RHEL: rm -rf $RPM_BUILD_ROOT %if 0%{?rhel} %clean rm -rf $RPM_BUILD_ROOT %endif - Group: is not used in Fedora (In reply to Jani Juhani Sinervo from comment #2) > Here's a preliminary (unofficial) review. Some points I thought would be > useful: > > - Even though this is a development package by itself, and thus as far as I > can tell an unversioned .so-file is acceptable, I would still try to make > the _cqueues.so into a versioned .so-file, and then maybe creating an > symbolic link from that versioned file to _cqueues.so. > It's in a private dir, so it doesn't really matter. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/2LVYMBV66GOAXW5NL5S5B63Y4DMJNFFE/
