[Bug 1540335] Review Request: primesieve - Fast C/ C++ prime number generator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #10 from Kim Walisch <kim.walisch@xxxxxxxxx> ---
Thanks for your review.

> Issues:
> - ldconfig called in %post and %postun if required.
> Note: /sbin/ldconfig not called in libprimesieve

I actually had that in an earlier version of primesieve.spec (see
https://github.com/kimwalisch/primesieve-rpm/commit/4604d88f2367181280ac6cc9acaff9b63eabfede#diff-d4de19401a23eecc5feccba05f2a05d9L48).
But following the suggestion of Jerry James (%post -p /sbin/ldconfig & %postun
-p /sbin/ldconfig should be replaced with this: %ldconfig_scriptlets) I
replaced that code by %ldconfig_scriptlets. So can we drop your ldconfig issue?

I have fixed the following Rpmlint error:

> primesieve.src: E: specfile-error warning: bogus date in %changelog: Thu Feb 16 2018 Kim Walisch <walki@xxxxxxxxxxxxxxxxx> - 6.4-4

The Rpmlint spelling-error warnings are false positives.


I have updated the primesieve package to the latest primesieve-7.0 version:

Spec URL:
https://raw.githubusercontent.com/kimwalisch/primesieve-rpm/v7.0-1/primesieve.spec
SRPM URL:
https://raw.githubusercontent.com/kimwalisch/primesieve-rpm/v7.0-1/primesieve-7.0-1.fc27.src.rpm

Hers's the link to the successful koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=28083380

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/E4XVWEYKSMTE7AI3RMGWU3FMOIIYABJN/




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux