[Bug 1596922] Review Request: python-pipdeptree - Command line utility to show dependency tree of package

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1596922



--- Comment #8 from Dhanesh B. Sabane <dhanesh95@xxxxxxxxxxx> ---
(In reply to Miro Hrončok from comment #7)
> https://apps.fedoraproject.org/packages/pytest
> 
> Rawhide has 3.6.2-3.fc29
> 

Ahh.. I thought F28 had pytest 3.6

> You can do:
> 
> %if %{fedora} > 28
> ...testy testy test...
> %endif
> 
> if you want single spec.
> 
> Also, have you actually tried with pytest 3.4 and seen that it failed?

I don't think I'll have to do that. After taking some time to understand the
upstream code and the tests, I figured that the tests are run under a virtual
environment. See test-env and test target in the Makefile [1]. So the only
package required for the tests is tox (any version) so as to avoid the `pip
install tox` action in the Makefile.

I've made the required changes to the spec and pushed them [2] [3]. However,
are you sure that this is a safe way to run the tests? I'm a bit skeptical
about pip running as root to install the test dependencies.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/FDSRFGEJK6KE6IJGMKS252SD22ZNA2DX/




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux