https://bugzilla.redhat.com/show_bug.cgi?id=1597417 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Could you add a comment before the patch to explain what it does. - There's no tests provided so you can remove %check - Another issue is that you're using python2-tox which has been removed from Fedora. This is not really needed to use the library so you can safely remove it. - Install the docs: BuildRequires: python2-sphinx %package doc Summary: pwntools documentation %description doc Documentation for pwntools %build %py2_build # generate html docs PYTHONPATH=${PWD} sphinx-build-2 docs/source html # remove the sphinx-build leftovers rm -rf html/.{doctrees,buildinfo} %files doc %doc html %license LICENSE-pwntools.txt (might need other BR) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/ZYIVPEQDXLE75V634PLPEL2YEV3M3CUG/
