[Bug 1597391] Review Request: mediawiki-backtick-code - mediawiki extension - allows inline code snippets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1597391



--- Comment #3 from zachvatwork@xxxxxxxxx ---
Thanks for the review! I am working on these items.


(In reply to Robert-André Mauchin from comment #2)
>  - Not needed
> 
> BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> 
> rm -rf %{buildroot}
> 
>  - The archive seems corrupted. I don't manage to open it. Same with the
> SRPM. I think the correct Source0 should be:
> 
> https://pagure.io/mediawiki-backtick-code-extension/raw/master/f/mediawiki-
> backtick-code-0.0.2.tar.gz
>  
>  - You should own this directory:
> 
> [!]: Package must own all directories that it creates.
>      Note: Directories without known owners:
>      /usr/share/mediawiki/extensions/BacktickCode
> 
> %dir %{_datadir}/mediawiki/extensions/BacktickCode
> 
>  - The changelog entry must contain your name, email and the Version-Release
> info:


> [x]: Package requires other packages for directories it uses.
>      Note: No known owner of /usr/share/mediawiki/extensions/BacktickCode
> [!]: Package must own all directories that it creates.
>      Note: Directories without known owners:
>      /usr/share/mediawiki/extensions/BacktickCode

> [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>      beginning of %install.
>      Note: rm -rf %{buildroot} present but not required

> ===== SHOULD items =====
> 
> Generic:
> [!]: Buildroot is not present
>      Note: Buildroot: present but not needed
> [?]: Package functions as described.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/XXX6LSRLXIT3VGYNBAWBPSD3IQDD5F6T/




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux