[Bug 1491281] Review Request: python-libsass - python bindings for libsass

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1491281



--- Comment #21 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
BuildRequires:  python2-devel python2-six python2-pytest python-werkzeug
BuildRequires:  python3-devel python3-six python3-pytest python3-werkzeug

1) as a matter of style, i recommend putting each BR on new line. it's better
with diffs, commits, etc.

2) python-werkzeug -> python2-werkzeug

----

PLATFORM=...

why si this needed? maybe add a comment

-----

py.test-%{python2_version} -> py.test-2
py.test-%{python3_version} -> py.test-3

-----

%exclude %{_bindir}/sassc
%exclude %{_bindir}/sassc.py

add a comment?

-----


Also, consider not doing the python2 package at all.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/IVW5Y7QUTSXFHA3MFG3S5NQ3L7VS65GK/




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux