https://bugzilla.redhat.com/show_bug.cgi?id=1596278 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review+ --- Comment #5 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- (In reply to Bastien Nocera from comment #2) > > > - The changelog entry should contain the version-release info: > > > > * Thu Jun 28 2018 Bastien Nocera <bnocera@xxxxxxxxxx> - > > 0-0.1.20180628gitbe55741 > > My vim macros can't generate it. This is tagged in the repo, so why is this > important? > To link the changelog message to the version? There has been discussion about removing the %changelog and use the git tag instead but nothing definitive yet. You'll get an RPMLINT error if you don't include it. > > - Use: > > > > %global short_gittag %(c=%{gittag}; echo ${c:0:7}) > > Done. Why is this not mentioned in the packaging guidelines? > https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots > It is mentioned here: https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Hosting_Services Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/6AJEGSC4FAVRU4HDZWZUJCUJLYBLBXN6/
