https://bugzilla.redhat.com/show_bug.cgi?id=1596727 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Why %{__python3} setup.py --help after the Sphinx build? - Splitting the doc in a separate package would be better - Unbundle the fonts: html/_static/fonts/Inconsolata-Bold.ttf html/_static/fonts/Inconsolata-Regular.ttf html/_static/fonts/Lato-Bold.ttf html/_static/fonts/Lato-BoldItalic.ttf html/_static/fonts/Lato-Italic.ttf html/_static/fonts/Lato-Regular.ttf html/_static/fonts/RobotoSlab-Bold.ttf html/_static/fonts/RobotoSlab-Regular.ttf html/_static/fonts/fontawesome-webfont.eot html/_static/fonts/fontawesome-webfont.svg html/_static/fonts/fontawesome-webfont.ttf html/_static/fonts/fontawesome-webfont.woff html/_static/fonts/fontawesome-webfont.woff2 - Unbundle the JS html/_static/jquery-3.2.1.js html/_static/jquery.js html/_static/underscore-1.3.1.js html/_static/underscore.js # Unbundle fonts and JS BuildRequires: fontawesome-fonts BuildRequires: fontawesome-fonts-web BuildRequires: lato-fonts BuildRequires: google-roboto-slab-fonts BuildRequires: levien-inconsolata-fonts BuildRequires: js-underscore BuildRequires: js-jquery And: %package doc Summary: Documentation for %{name} Requires: fontawesome-fonts Requires: fontawesome-fonts-web Requires: lato-fonts Requires: google-roboto-slab-fonts Requires: levien-inconsolata-fonts Requires: js-underscore Requires: js-jquery %description doc This project implements an object model based SDK for the F5 Networks® BIG-IP® iControl® REST interface. Users of this library can create, edit, update, and delete configuration objects on a BIG-IP®. This is the documentation package for %{name}. Then after the make doc: # Unbundle fonts pushd docs/_build/html/_static/fonts/ for file in fontawesome*; do rm -f $file ln -s /usr/share/fonts/fontawesome/$file $file done for file in Lato*; do rm -f $file ln -s /usr/share/fonts/lato/$file $file done for file in RobotoSlab*; do rm -f $file ln -s /usr/share/fonts/google-roboto-slab/$file $file done for file in Inconsolata*; do rm -f $file ln -s /usr/share/fonts/levien-inconsolata/$file $file done popd # Unbundle JS rm -f docs/_build/html/_static/underscore.js ln -s /usr/share/javascript/underscore/underscore-min.js html/_static/underscore.js rm -f docs/_build/html/_static/underscore-1.3.1.js ln -s /usr/share/javascript/underscore/underscore.js html/_static/underscore-1.3.1.js rm -f docs/_build/html/_static/jquery.js ln -s /usr/share/javascript/jquery/3.2.1/jquery.min.js html/_static/jquery.js rm -f docs/_build/html/_static/jquery-3.2.1.js ln -s /usr/share/javascript/jquery/3.2.1/jquery.js html/_static/jquery-3.2.1.js Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 31948800 bytes in 574 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 78 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/python-f5-sdk/review- python-f5-sdk/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: Uses parallel make %{?_smp_mflags} macro. [!]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-f5-sdk , python3-f5-sdk [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-f5-sdk-3.0.17-1.fc29.noarch.rpm python3-f5-sdk-3.0.17-1.fc29.noarch.rpm python-f5-sdk-3.0.17-1.fc29.src.rpm python2-f5-sdk.noarch: W: spelling-error %description -l en_US iControl -> i Control, control python3-f5-sdk.noarch: W: spelling-error %description -l en_US iControl -> i Control, control python-f5-sdk.src: W: spelling-error %description -l en_US iControl -> i Control, control 3 packages and 0 specfiles checked; 0 errors, 3 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/5257OOSMGTE4PO5QZJ2XSQ5OLFDWC4CZ/
