https://bugzilla.redhat.com/show_bug.cgi?id=1596293 Bug ID: 1596293 Summary: Review Request: gamemode - Optimise system performance for games on demand Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@xxxxxxxxxxxxxxxxx Reporter: ckellner@xxxxxxxxxx QA Contact: extras-qa@xxxxxxxxxxxxxxxxx CC: package-review@xxxxxxxxxxxxxxxxxxxxxxx Spec URL: https://github.com/gicmo/spec/blob/master/gamemode/gamemode.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/gicmo/nursery/fedora-rawhide-x86_64/00772034-gamemode/gamemode-1.1-1.fc29.src.rpm Copr URL: https://copr.fedorainfracloud.org/coprs/gicmo/nursery Fedora Account System Username: gicmo Description: GameMode is a daemon/lib combo for GNU/Linux that allows games to request a set of optimisations be temporarily applied to the host OS. GameMode was designed primarily as a stop-gap solution to problems with the Intel and AMD CPU powersave or ondemand governors, but is now able to launch custom user defined plugins, and is intended to be expanded further, as there are a wealth of automation tasks one might want to apply. I did a scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=27918810 After manually enabling the user unit file, I tested that it is working as expected: Jun 28 17:03:17 cobalt /usr/bin/gamemoded[5802]: Adding game: 6209 [/usr/bin/sleep] Jun 28 17:03:17 cobalt /usr/bin/gamemoded[5802]: Entering Game Mode... Jun 28 17:03:17 cobalt /usr/bin/gamemoded[5802]: Requesting update of governor policy to performance Jun 28 17:03:17 cobalt pkexec[6210]: pam_systemd(polkit-1:session): Cannot create session: Already running in a session Jun 28 17:03:17 cobalt pkexec[6210]: pam_unix(polkit-1:session): session opened for user root by (uid=1000) Jun 28 17:03:17 cobalt gamemoded[5802]: Setting governors to performance Jun 28 17:04:17 cobalt /usr/bin/gamemoded[5802]: Removing game: 6209 [/usr/bin/sleep] Jun 28 17:04:18 cobalt gamemoded[5802]: Setting governors to powersave Jun 28 17:04:17 cobalt /usr/bin/gamemoded[5802]: Leaving Game Mode... Jun 28 17:04:17 cobalt /usr/bin/gamemoded[5802]: Requesting update of governor policy to powersave I think there are a couple of issues with the package, I think they should be fixed upstream, which I would like to get feedback here too: * Issues - location of the gamemoded daemon (currently /usr/bin) Why is it not in /usr/libexec/ (or better /usr/libexec/gamemode) - location of the libraries (currently /usr/lib) They are unversioned, but maybe that is ok, because they are internal, i.e. get dlopen'ed by the inlined functions from the inlined functions in the header. - system user vs system unit What is the reason that this is a user unit file, not a system one? Currently needs manual enablement and starting. - man page section for gamemoded (1 vs 8) It is a daemon, so should be in secton 8? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/OM67NNL3ZRNBS7AASFICFCPEM5R6FW4U/
