https://bugzilla.redhat.com/show_bug.cgi?id=1594313 --- Comment #17 from Severin Gehwolf <sgehwolf@xxxxxxxxxx> --- # to regenerate source0 and source1(shenandaoh hotspot) run update_package.sh # update_package.sh contains hardcoded repos, revisions, tags, and projects to regenerate the source archives # at the end it sed specfile and sources to match those new names # FIXME adapt the script to work better on shenandoah hotspot (After the jdk10 and removal of forest). Current source1 was done by manual delete # FIXME: adapt the sed to new specfile and sources or drop those parts # next update will be used to tweek those two files Source0: jdk-jdk-jdk-%{majorver}+%{buildver}.tar.xz I'm missing a short and concise: # Use this to generate the source tarball: # $ VERSION="jdk-11+19" PROJECT_NAME=jdk REPO_NAME=jdk \ # bash generate_source_tarball.sh # Shenandoah HotSpot # current name used with tip and bleading edge may be incorrect Source1: jdk-shenandoah-jdk-ac148db384ee.tar.xz With JDK 11 I'm doubtful we should continue with the different hotspot for shenandoah arches approach. One single tarball for all arches would be better. We'll discuss this elsewhere. I'd suggest to leave shenandoah out for now and add it back in when the upstream repos are ready. # Systemtap tapsets. Zipped up to keep it small # Use 'generate_tarballs.sh' to generate the following tarballs # They are based on code contained in the IcedTea7 project # The script have hardcoded url and revision # FIXME discover what exactly is current systemtap from or # FIXME current systemtap is not working, new version is necessary Source8: systemtap-tapset-3.6.0pre02.tar.xz All of those comments above suggest we don't have a good way to regenerate each tarball. I have a feeling that update_package.sh has too many responsibilities. Ideally there would be one script or one command per tarball doing just that: producing one source tarball in a reproducible way! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/CZM34MN233R4YDMLMBBGHUARAOCALZKB/
