https://bugzilla.redhat.com/show_bug.cgi?id=1559864 Sachidananda Urs <surs@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(surs@xxxxxxxxxx) | --- Comment #7 from Sachidananda Urs <surs@xxxxxxxxxx> --- (In reply to Venkata R Edara from comment #4) > Sorry for delay, I made changes to spec file , now the build is success. > > SPEC: > https://github.com/gluster/gluster-collectd/blob/master/gluster-collectd.spec > * Instead of /usr/share use the _datadir macro. > Requires : collectd >= 5.8.0 > Requires : collectd-python >= 5.8.0 If the fedora releases targeted has latest above 5.8.x you can ignore the version numbers. > %{__python2} setup.py build * py2_build macro should achieve this. Have you tried it? Below is a comment from Ken Dreyer from another package. Since I see python2 in many places, I think it is still relevant. Can this package work with Python 3 instead of Python 2? Maybe it would be a good idea to add a comment to the .spec file explaining why this will not work with Python 3 if that is the case. https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3 is coming eventually. You could conditionalize py2/py3 with "%if %{?rhel} < 8" if you want to share the same .spec file across RHEL 7 and Fedora. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/LJZ44N2MSUVG3YDFFEEMQ6FCOFD5DEDQ/
