https://bugzilla.redhat.com/show_bug.cgi?id=1570047 --- Comment #13 from William Moreno <williamjmorenor@xxxxxxxxx> --- Package Review ============== Issues: ======= Please doble check is this can be move to a -devel package. [!]: Development files must be in a -devel package - Header files in -devel subpackage, if present. Note: prestopalette-debugsource : /usr/src/debug/prestopalette-0.1.31-1.fc29.x86_64/aboutdialog.h prestopalette-debugsource : /usr/src/debug/prestopalette-0.1.31-1.fc29.x86_64/circlepalette.h prestopalette-debugsource : /usr/src/debug/prestopalette-0.1.31-1.fc29.x86_64/clickablelabel.h prestopalette-debugsource : /usr/src/debug/prestopalette-0.1.31-1.fc29.x86_64/gui_aboutdialog.h prestopalette-debugsource : /usr/src/debug/prestopalette-0.1.31-1.fc29.x86_64/gui_mainwindow.h prestopalette-debugsource : /usr/src/debug/prestopalette-0.1.31-1.fc29.x86_64/lightingsliderstyle.h prestopalette-debugsource : /usr/src/debug/prestopalette-0.1.31-1.fc29.x86_64/mainwindow.h prestopalette-debugsource : /usr/src/debug/prestopalette-0.1.31-1.fc29.x86_64/visualpalette.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: prestopalette-0.1.31-1.fc29.x86_64.rpm prestopalette-debuginfo-0.1.31-1.fc29.x86_64.rpm prestopalette-debugsource-0.1.31-1.fc29.x86_64.rpm prestopalette-0.1.31-1.fc29.src.rpm prestopalette.x86_64: W: no-documentation prestopalette.x86_64: W: no-manual-page-for-binary PrestoPalette 4 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (debuginfo) ------------------- Checking: prestopalette-debuginfo-0.1.31-1.fc29.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory prestopalette-debuginfo.x86_64: W: invalid-url URL: https://github.com/PrestoPalette/PrestoPalette <urlopen error [Errno -2] Name or service not known> prestopalette.x86_64: W: invalid-url URL: https://github.com/PrestoPalette/PrestoPalette <urlopen error [Errno -2] Name or service not known> prestopalette.x86_64: W: no-documentation prestopalette.x86_64: W: no-manual-page-for-binary PrestoPalette prestopalette-debugsource.x86_64: W: invalid-url URL: https://github.com/PrestoPalette/PrestoPalette <urlopen error [Errno -2] Name or service not known> 3 packages and 0 specfiles checked; 0 errors, 5 warnings. Requires -------- prestopalette-debuginfo (rpmlib, GLIBC filtered): prestopalette (rpmlib, GLIBC filtered): libGL.so.1()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.11)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Multimedia.so.5()(64bit) libQt5Multimedia.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) prestopalette-debugsource (rpmlib, GLIBC filtered): Provides -------- prestopalette-debuginfo: debuginfo(build-id) prestopalette-debuginfo prestopalette-debuginfo(x86-64) prestopalette: application() application(PrestoPalette.desktop) metainfo() metainfo(PrestoPalette.appdata.xml) prestopalette prestopalette(x86-64) prestopalette-debugsource: prestopalette-debugsource prestopalette-debugsource(x86-64) Source checksums ---------------- https://raw.githubusercontent.com/PrestoPalette/PrestoPalette-Packaging/master/Fedora/Icon.png#/PrestoPalette.png : CHECKSUM(SHA256) this package : 3d92aeb896aeb87be37ca0c23150ecee166c9205c4017f4801849f326a73c951 CHECKSUM(SHA256) upstream package : 3d92aeb896aeb87be37ca0c23150ecee166c9205c4017f4801849f326a73c951 https://github.com/PrestoPalette/PrestoPalette/archive/0.1.31/0.1.31.tar.gz#/prestopalette-0.1.31.tar.gz : CHECKSUM(SHA256) this package : bdad1bec87a1a8c53f95c841d66f298f8a0ada858f7baa3e69ae168796d8b313 CHECKSUM(SHA256) upstream package : bdad1bec87a1a8c53f95c841d66f298f8a0ada858f7baa3e69ae168796d8b313 https://raw.githubusercontent.com/PrestoPalette/PrestoPalette-Packaging/master/Fedora/PrestoPalette.appdata.xml#/PrestoPalette.appdata.xml : CHECKSUM(SHA256) this package : e96a60e52af9e8f57c22f5076cdfaf6f51d79167852dcb85c28f4fac9362f41e CHECKSUM(SHA256) upstream package : e96a60e52af9e8f57c22f5076cdfaf6f51d79167852dcb85c28f4fac9362f41e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/IAA2YH3NI3SDYISL6TAP6HG2TYZ44AJH/
