https://bugzilla.redhat.com/show_bug.cgi?id=1594858 --- Comment #2 from Till Hofmann <thofmann@xxxxxxxxxxxxxxxxx> --- Spec URL: https://thofmann.fedorapeople.org/tiny-dnn/tiny-dnn.spec SRPM URL: https://thofmann.fedorapeople.org/tiny-dnn/tiny-dnn-1.0.0-0.a3.3.fc28.src.rpm Thanks for reviewing! Changes: - Add missing BR: gcc-c++ - Only provide devel subpackage - Remove BuildArch: noarch (should not be used for header only libs) - Add virtual provide for tiny-dnn-static (following guidelines for header only libs) For the last two points, also see https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Header_Only_Libraries. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/UJ36VEVRFBFJDJALCCUWGXIAN6CX7MW2/
