https://bugzilla.redhat.com/show_bug.cgi?id=1594313 --- Comment #5 from jiri vanek <jvanek@xxxxxxxxxx> --- (In reply to Severin Gehwolf from comment #3) > Source0: jdk-jdk-jdk-%{majorver}+%{buildver}.tar.xz > Source1: jdk-shenandoah-jdk-ac148db384ee.tar.xz > Source8: systemtap-tapset-3.6.0pre02.tar.xz > > Each of these sources should have a comment preceding them how *exactly* the > tarball was generated. I've been asked before by other fedora contributors > how our sources are generated. When being asked I mostly don't remember > myself and need to go digging. If every source was preceded by a comment > where it came from those issues go away. Example: > > # Generated by: > # $ VERSION="jdk-11+19" PROJECT_NAME=jdk REPO_NAME=jdk bash This kind of comment should not be necessary. Those valueas are exactly for this purpose hardcoded in update_package.sh > generate_source_tarball.sh > Source0: jdk-jdk-jdk-%{majorver}+%{buildver}.tar.xz > [...] Still I agree on improvement here. TBD! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/EX6HMRJ4YN3R7BEIOZYPDK2S2OTIR5TQ/
