https://bugzilla.redhat.com/show_bug.cgi?id=1585565 --- Comment #6 from Mohammed Isam <mohammed_isam1984@xxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #5) > - Please use your Fedora People space instead of Google to host your files, Done. New links are added below. > - Not needed: > %defattr(-,root,root,-) Removed. > - Install the doc but without COPYING: > %doc AUTHORS NEWS THANKS README ChangeLog > %license COPYING Fixed. > - %{_datadir}/metainfo → %{_metainfodir} (F28+ only) Fixed. > - Remove: > update-desktop-database &> /dev/null ||: Removed. > - This shouldn't be necessary as you already installing the man page with > 644 perm: > chmod -x %{buildroot}%{_mandir}/man1/shaman.1 Removed. > - Not needed: > Requires(post): info > Requires(post): desktop-file-utils > Requires(preun): info > Requires(post): desktop-file-utils Removed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/7AOCYMZGD2RDD54ARQXL5A5XGKGSIS3K/
