[Bug 1594430] Review Request: python-ROPGadget - A tool to find ROP gadgets in program files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1594430



--- Comment #3 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
(In reply to Robert-André Mauchin from comment #2)
>  - %{_bindir}/* should only be installed with the latest binaries you
> installed with py_install, so in the python3 subpackage. If you want to
> install both Python 2 and Python 3 binaries, copy them with a suffix:
> 
> %install
> %py2_install
> mv %{buildroot}%{_bindir}/%{srcname}
> %{buildroot}%{_bindir}/%{srcname}-%{python2_version}
> ln -s %{_bindir}/%{srcname}-%{python2_version}
> %{buildroot}%{_bindir}/%{srcname}-2
> %py3_install
> mv %{buildroot}%{_bindir}/%{srcname}
> %{buildroot}%{_bindir}/%{srcname}-%{python3_version}
> ln -s %{_bindir}/%{srcname}-%{python3_version}
> %{buildroot}%{_bindir}/%{srcname}-3
> ln -s %{_bindir}/%{srcname}-%{python3_version}
> %{buildroot}%{_bindir}/%{srcname}
> 
>   Then in %files:
> 
> %files -n python2-%{srcname}
> %{_bindir}/%{srcname}-%{python2_version}
> %{_bindir}/%{srcname}-2
> 
> %files -n python3-%{srcname}
> %{_bindir}/%{srcname}-%{python3_version}
> %{_bindir}/%{srcname}-3
> %{_bindir}/%{srcname}


Please don't. Juts put them to the python3 package. Unless you provide a good
reason why ROPGadget should behave differently under python3 and python2.

Pro tip: is the python2 package even needed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/47GOAEAPVLXPS2MCLAYBCL5DGKBPZEHF/




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux