https://bugzilla.redhat.com/show_bug.cgi?id=1586291 --- Comment #9 from Alois Mahdal <amahdal@xxxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #7) > - Use a more meaningful name for your archive: > > Source0: > https://github.com/naelstrof/slop/archive/v%{version}/%{name}-%{version}.tar. > gz Well I don't see how I can control that. Upstream only provides this link, which I assume is auto-generated by GiitHub release scripting. > - The summary is too vague. Please be more descriptive about what this > program do. DONE. > - libslopy-devel should Requires libslopy: > > %package -n libslopy-devel > Summary: Select Operation > Requires: libslopy%{?_isa} = %{version}-%{release} I've added them back, although note that IIUC Vít's comment 1 seems to suggest that they should be generated by cmake, and with previous builds I could observe that was the case. > - If you package for F27, do use: > > %ldconfig_scriptlets DONE. I was not sure if you meant that exact syntax, so I looked for examples and come to conclusion that it should be `%ldconfig_scriptlets -n libslopy`. > - Use a * instead of .gz as the compression can change in the future: > > %{_mandir}/man1/slop.1.* DONE. > - You must install the COPYING license file amd should install the README > > %license COPYING license.txt > %doc README.md DONE. ~ Thanks, Robert-André, I'll provide updated files in few minutes. (Note that I've updated my workstation to F28 in the meantime, so new examples will show that.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/H4VQQZHHNSUCQPBU6GOS643WJ7SZGZ6F/
