https://bugzilla.redhat.com/show_bug.cgi?id=1594431 Marcel Plch <mplch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mplch@xxxxxxxxxx --- Comment #1 from Marcel Plch <mplch@xxxxxxxxxx> --- Note that I am not a packager yet and this is an informal review. ----------------------------------------------------------------- 1) The license is quite unclear. The src/README.md speaks of GPL, but doesn't specify version. It also points to non/existing COPYING file. 2) Please, do not use %{pythonX_sitelib}/*, it might make your package own things that do not belong to your package (like __pycache__). 3) Your package bundles libunicorn. It would be better to package that first and then just make the bindings use the system library. 4) If upstream doesn't provide the license file, please contact them to include it. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Header files in -devel subpackage, if present. Note: python2-unicorn : /usr/lib/python2.7/site- packages/unicorn/include/unicorn/arm.h python2-unicorn : /usr/lib/python2.7/site-packages/unicorn/include/unicorn/arm64.h python2-unicorn : /usr/lib/python2.7/site- packages/unicorn/include/unicorn/m68k.h python2-unicorn : /usr/lib/python2.7/site-packages/unicorn/include/unicorn/mips.h python2-unicorn : /usr/lib/python2.7/site- packages/unicorn/include/unicorn/sparc.h python2-unicorn : /usr/lib/python2.7/site-packages/unicorn/include/unicorn/unicorn.h python2-unicorn : /usr/lib/python2.7/site- packages/unicorn/include/unicorn/x86.h python3-unicorn : /usr/lib/python3.6/site-packages/unicorn/include/unicorn/arm.h python3-unicorn : /usr/lib/python3.6/site- packages/unicorn/include/unicorn/arm64.h python3-unicorn : /usr/lib/python3.6/site-packages/unicorn/include/unicorn/m68k.h python3-unicorn : /usr/lib/python3.6/site- packages/unicorn/include/unicorn/mips.h python3-unicorn : /usr/lib/python3.6/site-packages/unicorn/include/unicorn/sparc.h python3-unicorn : /usr/lib/python3.6/site- packages/unicorn/include/unicorn/unicorn.h python3-unicorn : See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - Static libraries in -static or -devel subpackage, providing -devel if present. Note: the script is complaining about debugsources headers. Note: Package has .a files: python2-unicorn, python3-unicorn. Illegal package name: python2-unicorn, python3-unicorn. Does not provide -static: python2-unicorn, python3-unicorn. See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [!]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL", "LGPL (v2)", "*No copyright* LGPL (v2 or later)", "LGPL (v2 or later)", "GPL (v2 or later)", "*No copyright* GPL (v2)", "Unknown or generated", "*No copyright* GPL", "MIT/X11 (BSD like)", "*No copyright* MIT/X11 (BSD like)", "LGPL", "*No copyright* BSD (unspecified)", "BSD (3 clause)", "LGPL (v2.1 or later)", "GPL (v2)", "CC0 LGPL (v2 or later)". 275 files have unknown license. Detailed output of licensecheck in /home/mplch/reviews/1594431-python- unicorn/licensecheck.txt [-]: License file installed when any subpackage combination is installed. [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/.build-id(libmad, libhbalinux, cups-client, efivar-libs, netcdf, xml-security-c, qemu- block-gluster, rpm-plugin-selinux, abrt, libmediaart, libimagequant, giflib, libreoffice-graphicfilter, trousers, libdb-utils, tracker- miners, xorg-x11-font-utils, PackageKit-command-not-found, OpenEXR- libs, libcom_err, libseccomp, kmod-VirtualBox-4.16.13-200.fc27.x86_64, p11-kit...) [x]: %build honors applicable compiler flags or justifies otherwise. [!]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [!]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-unicorn , python3-unicorn , python-unicorn-debuginfo , python- unicorn-debugsource [x]: Package functions as described. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-unicorn-1.0.1-1.fc29.x86_64.rpm python3-unicorn-1.0.1-1.fc29.x86_64.rpm python-unicorn-debuginfo-1.0.1-1.fc29.x86_64.rpm python-unicorn-debugsource-1.0.1-1.fc29.x86_64.rpm python-unicorn-1.0.1-1.fc29.src.rpm python2-unicorn.x86_64: E: description-line-too-long C Unicorn is a lightweight multi-platform, multi-architecture CPU emulator framework. python2-unicorn.x86_64: W: private-shared-object-provides /usr/lib/python2.7/site-packages/unicorn/lib/libunicorn.so libunicorn.so.1()(64bit) python2-unicorn.x86_64: E: no-ldconfig-symlink /usr/lib/python2.7/site-packages/unicorn/lib/libunicorn.so python2-unicorn.x86_64: W: shared-lib-calls-exit /usr/lib/python2.7/site-packages/unicorn/lib/libunicorn.so exit@GLIBC_2.2.5 python2-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python2.7/site-packages/unicorn/include/unicorn/arm.h python2-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python2.7/site-packages/unicorn/include/unicorn/arm64.h python2-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python2.7/site-packages/unicorn/include/unicorn/m68k.h python2-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python2.7/site-packages/unicorn/include/unicorn/mips.h python2-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python2.7/site-packages/unicorn/include/unicorn/sparc.h python2-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python2.7/site-packages/unicorn/include/unicorn/unicorn.h python2-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python2.7/site-packages/unicorn/include/unicorn/x86.h python2-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python2.7/site-packages/unicorn/lib/libunicorn.a python3-unicorn.x86_64: E: description-line-too-long C Unicorn is a lightweight multi-platform, multi-architecture CPU emulator framework. python3-unicorn.x86_64: W: private-shared-object-provides /usr/lib/python3.6/site-packages/unicorn/lib/libunicorn.so libunicorn.so.1()(64bit) python3-unicorn.x86_64: E: no-ldconfig-symlink /usr/lib/python3.6/site-packages/unicorn/lib/libunicorn.so python3-unicorn.x86_64: W: shared-lib-calls-exit /usr/lib/python3.6/site-packages/unicorn/lib/libunicorn.so exit@GLIBC_2.2.5 python3-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python3.6/site-packages/unicorn/include/unicorn/arm.h python3-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python3.6/site-packages/unicorn/include/unicorn/arm64.h python3-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python3.6/site-packages/unicorn/include/unicorn/m68k.h python3-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python3.6/site-packages/unicorn/include/unicorn/mips.h python3-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python3.6/site-packages/unicorn/include/unicorn/sparc.h python3-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python3.6/site-packages/unicorn/include/unicorn/unicorn.h python3-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python3.6/site-packages/unicorn/include/unicorn/x86.h python3-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python3.6/site-packages/unicorn/lib/libunicorn.a python-unicorn.src: E: description-line-too-long C Unicorn is a lightweight multi-platform, multi-architecture CPU emulator framework. 5 packages and 0 specfiles checked; 5 errors, 20 warnings. Rpmlint (debuginfo) ------------------- Checking: python-unicorn-debuginfo-1.0.1-1.fc29.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- python3-unicorn.x86_64: E: description-line-too-long C Unicorn is a lightweight multi-platform, multi-architecture CPU emulator framework. python3-unicorn.x86_64: E: no-ldconfig-symlink /usr/lib/python3.6/site-packages/unicorn/lib/libunicorn.so python3-unicorn.x86_64: W: undefined-non-weak-symbol /usr/lib/python3.6/site-packages/unicorn/lib/libunicorn.so pthread_sigmask python3-unicorn.x86_64: W: undefined-non-weak-symbol /usr/lib/python3.6/site-packages/unicorn/lib/libunicorn.so pthread_create python3-unicorn.x86_64: W: undefined-non-weak-symbol /usr/lib/python3.6/site-packages/unicorn/lib/libunicorn.so pthread_join python3-unicorn.x86_64: W: shared-lib-calls-exit /usr/lib/python3.6/site-packages/unicorn/lib/libunicorn.so exit@GLIBC_2.2.5 python3-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python3.6/site-packages/unicorn/include/unicorn/arm.h python3-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python3.6/site-packages/unicorn/include/unicorn/arm64.h python3-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python3.6/site-packages/unicorn/include/unicorn/m68k.h python3-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python3.6/site-packages/unicorn/include/unicorn/mips.h python3-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python3.6/site-packages/unicorn/include/unicorn/sparc.h python3-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python3.6/site-packages/unicorn/include/unicorn/unicorn.h python3-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python3.6/site-packages/unicorn/include/unicorn/x86.h python3-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python3.6/site-packages/unicorn/lib/libunicorn.a python2-unicorn.x86_64: E: description-line-too-long C Unicorn is a lightweight multi-platform, multi-architecture CPU emulator framework. python2-unicorn.x86_64: W: private-shared-object-provides /usr/lib/python2.7/site-packages/unicorn/lib/libunicorn.so libunicorn.so.1()(64bit) python2-unicorn.x86_64: E: no-ldconfig-symlink /usr/lib/python2.7/site-packages/unicorn/lib/libunicorn.so python2-unicorn.x86_64: W: undefined-non-weak-symbol /usr/lib/python2.7/site-packages/unicorn/lib/libunicorn.so pthread_sigmask python2-unicorn.x86_64: W: undefined-non-weak-symbol /usr/lib/python2.7/site-packages/unicorn/lib/libunicorn.so pthread_create python2-unicorn.x86_64: W: undefined-non-weak-symbol /usr/lib/python2.7/site-packages/unicorn/lib/libunicorn.so pthread_join python2-unicorn.x86_64: W: shared-lib-calls-exit /usr/lib/python2.7/site-packages/unicorn/lib/libunicorn.so exit@GLIBC_2.2.5 python2-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python2.7/site-packages/unicorn/include/unicorn/arm.h python2-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python2.7/site-packages/unicorn/include/unicorn/arm64.h python2-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python2.7/site-packages/unicorn/include/unicorn/m68k.h python2-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python2.7/site-packages/unicorn/include/unicorn/mips.h python2-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python2.7/site-packages/unicorn/include/unicorn/sparc.h python2-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python2.7/site-packages/unicorn/include/unicorn/unicorn.h python2-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python2.7/site-packages/unicorn/include/unicorn/x86.h python2-unicorn.x86_64: W: devel-file-in-non-devel-package /usr/lib/python2.7/site-packages/unicorn/lib/libunicorn.a 4 packages and 0 specfiles checked; 4 errors, 25 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/VTBI6MCI7ACHTZTWUXH563ZML3PKGGEH/
