Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libzzub - Powerful music sequencing library https://bugzilla.redhat.com/show_bug.cgi?id=275831 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-09-10 10:06 EST ------- For 0.2.3-3: Almost good. * Internal library - build log says: ---------------------------------------------------------- gcc -o src/flac/src/libFLAC/bitbuffer.o -c <snip> src/flac/src/libFLAC/bitbuffer.c <snip> ar rc lib/libFLAC.a src/flac/src/libFLAC/bitbuffer.o <snip> <snip> g++ -o lib/libzzub.so.0.2.3 <snip> -Llib -lFLAC -lz -ldl -lpthread -lsndfile -lasound -lrtaudio_static -lasound -ljack -lrt -lpthread -lm ---------------------------------------------------------- Here the internal libFLAC is used. However flac-devel is in Fedora so please fix the source code so that libzzub.so uses external libFLAC.so. * Documents - The file "INSTALL" is for people who want to compile and install this by themselves and not needed for people who install this package using rpm. * Source0 - is written twice - Well, now you have disabled MP3 support. However Fedora requests that you have to remove MP3 support even on source code devel. So, please - first remove mp3 support part from libzzub tarball. As far as I am correct, you have to * remove src/libmad * and remove USE_LIBMAD part from src/libzzub/libzzub.cpp - And repackage it as libzzub-0.2.3-fe.tar.bz2, for example and use it as Source0 - Add a comment in the spec file like ------------------------------------------------------------- # The original source code is from: # http://download.sourceforge.net/.... # # For fedora tarball, the MP3 support parts are removed # - src/libmad : completely removed # - src/libzzub/libzzub.cpp: removed MP3 support part Source0: libzzub-0.2.3-fe.tar.bz2 -------------------------------------------------------------- * About python: > libzzub is usually used in conjunction with pyzzub - Then pyzzub should have "Requires: python" and libzzub need not require python. > Is it save to remove the explicit require, i.e. for cases of downgrading what > would break the package? - Thinking about "downgrade" is a "very specific" case and in that case usually extra consideration is needed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review