[Bug 1592782] Review Request: perl-Syntax-Keyword-Gather - Implements the Perl 6 'gather/take' control structure in Perl 5

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1592782

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |zebob.m@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zebob.m@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
URL and Source addresses are Ok.
Source archive (SHA-256:
8bd62205e1645c0915d28340801f245e4551b4f580f5e2735a39fc426c066207) is original.
Ok.
Summary verified from lib/Syntax/Keyword/Gather.pm. Ok.
Description verified from lib/Syntax/Keyword/Gather.pm. Ok.
License verified from lib/Syntax/Keyword/Gather.pm and LICENSE. Ok.
No XS code, noarch BuildArch is Ok.

All tests pass. Ok.

$ rpmlint perl-Syntax-Keyword-Gather.spec
review-perl-Syntax-Keyword-Gather/results/perl-Syntax-Keyword-Gather-1.003002-1.fc29.noarch.rpm
review-perl-Syntax-Keyword-Gather/results/perl-Syntax-Keyword-Gather-1.003002-1.fc29.src.rpm 
perl-Syntax-Keyword-Gather.noarch: W: spelling-error %description -l en_US
procedurally -> procedural
perl-Syntax-Keyword-Gather.src: W: spelling-error %description -l en_US
procedurally -> procedural
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

$ rpm -q -lv -p perl-Syntax-Keyword-Gather-1.003002-1.fc29.noarch.rpm
drwxr-xr-x    2 root    root                        0 juin 19 14:44
/usr/share/doc/perl-Syntax-Keyword-Gather
-rw-r--r--    1 root    root                     1172 févr. 16 15:42
/usr/share/doc/perl-Syntax-Keyword-Gather/Changes
-rw-r--r--    1 root    root                     5304 févr. 16 15:42
/usr/share/doc/perl-Syntax-Keyword-Gather/README
drwxr-xr-x    2 root    root                        0 juin 19 14:44
/usr/share/licenses/perl-Syntax-Keyword-Gather
-rw-r--r--    1 root    root                    18391 févr. 16 15:42
/usr/share/licenses/perl-Syntax-Keyword-Gather/LICENSE
-rw-r--r--    1 root    root                     3414 juin 19 14:44
/usr/share/man/man3/Syntax::Keyword::Gather.3pm.gz
drwxr-xr-x    2 root    root                        0 juin 19 14:44
/usr/share/perl5/vendor_perl/Syntax
drwxr-xr-x    2 root    root                        0 juin 19 14:44
/usr/share/perl5/vendor_perl/Syntax/Keyword
-rw-r--r--    1 root    root                     6997 févr. 16 15:42
/usr/share/perl5/vendor_perl/Syntax/Keyword/Gather.pm
File permissions and layout are Ok.

$ rpm -q --requires -p perl-Syntax-Keyword-Gather-1.003002-1.fc29.noarch.rpm |
sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.26.2)
      1 perl(Carp)
      1 perl(overload)
      1 perl(strict)
      1 perl(Sub::Exporter::Progressive)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p perl-Syntax-Keyword-Gather-1.003002-1.fc29.noarch.rpm
perl(Syntax::Keyword::Gather) = 1.003002
perl(Syntax::Keyword::Gather::MagicArrayRef) = 1.003002
perl-Syntax-Keyword-Gather = 1.003002-1.fc29
Binary provides are Ok.

Package builds in F29
(https://koji.fedoraproject.org/koji/taskinfo?taskID=27729985)
Ok

The package is in line with Fedora and Perl packaging guidelines.

Resolution: Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/BLT7ASLPIAGIHIGU5FNQW6IOPUQES5A2/




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux