https://bugzilla.redhat.com/show_bug.cgi?id=1592426 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- Difference in the spec file: --- perl-Crypt-OpenSSL-Guess.spec.old 2018-06-18 15:55:31.000000000 +0200 +++ perl-Crypt-OpenSSL-Guess.spec 2018-06-19 09:46:46.000000000 +0200 @@ -23,8 +23,9 @@ BuildRequires: perl(Test::More) >= 0.98 Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) Requires: perl(Exporter) >= 5.57 +Recommends: openssl -%global __requires_exclude %{?__requires_exclude}|perl\\(Exporter\\)\\s*$ +%global __requires_exclude %{?__requires_exclude:%__requires_exclude|}perl\\(Exporter\\)\\s*$ %description Crypt::OpenSSL::Guess provides helpers to guess OpenSSL include path on any > TODO: Recommend or suggest `openssl'. The Perl code executes "openssl" program > and without it it's pointless. Ok. $ rpmlint perl-Crypt-OpenSSL-Guess.spec ../SRPMS/perl-Crypt-OpenSSL-Guess-0.11-1.fc29.src.rpm ../RPMS/noarch/perl-Crypt-OpenSSL-Guess-0.11-1.fc29.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. > FIX: A typo in __requires_exclude definition (a pipe character out of > condition) erroneously filters all autogenerated dependencies. $ rpm -q --requires -p ../RPMS/noarch/perl-Crypt-OpenSSL-Guess-0.11-1.fc29.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.26.2) 1 perl(:VERSION) >= 5.8.1 1 perl(Config) 1 perl(Exporter) >= 5.57 1 perl(ExtUtils::MM) 1 perl(File::Spec) 1 perl(strict) 1 perl(Symbol) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Crypt-OpenSSL-Guess-0.11-1.fc29.noarch.rpm Binary dependencies resolvable. Ok. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/3GMYH64MJEC74IH334LXCMNU3FL2774L/
