[Bug 1592136] Review Request: perl-GraphViz2 - GraphViz2 Perl module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1592136

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |zebob.m@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zebob.m@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
URL and Source addresses are Ok.
Source archive (SHA-256:
37576e30a84bebcf94895505c3ce7507bc50fee4b690179c332d93f5cb16ad8b) is original.
Ok.
Summary verified from lib/GraphViz2.pm. Ok.
Description verified from lib/GraphViz2.pm. Ok.
License verified from lib/GraphViz2.pm and LICENSE. Ok.
No XS code, noarch BuildArch is Ok.


 - Build error:

Exécution_de(%build) : /bin/sh -e /var/tmp/rpm-tmp.eBnBjX
+ umask 022
+ cd /builddir/build/BUILD
+ cd GraphViz2-2.47
+ /usr/bin/perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1
BUILDSTDERR: Can't exec "dot": No such file or directory at Makefile.PL line
36.
BUILDSTDERR: Use of uninitialized value $stdout in pattern match (m//) at
Makefile.PL line 40.
BUILDSTDERR: Please install Graphviz from http://www.graphviz.org/

   Add:

BuildRequires:  graphviz


 - Tests fail:

Exécution_de(%check) : /bin/sh -e /var/tmp/rpm-tmp.yQdpVr
+ umask 022
+ cd /builddir/build/BUILD
+ cd GraphViz2-2.47
+ make test
PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness"
"-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')"
t/*.t
BUILDSTDERR: #   Failed test 'scripts/Heawood.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/anonymous.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/circo.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/cluster.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/dbi.schema.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/dependency.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/html.labels.1.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/html.labels.2.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/html.labels.3.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/jointed.edges.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/macro.1.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/macro.2.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/macro.3.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/macro.4.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/macro.5.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/parse.data.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/parse.html.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/parse.isa.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/parse.recdescent.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/parse.regexp.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/parse.stt.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/parse.xml.bare.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/parse.xml.pp.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/parse.yacc.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/parse.yapp.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/plaintext.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/quote.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/rank.sub.graph.1.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/rank.sub.graph.2.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/rank.sub.graph.3.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/rank.sub.graph.4.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/record.1.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/record.2.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/record.3.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/record.4.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/sub.graph.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/sub.graph.frames.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/sub.sub.graph.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/trivial.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: #   Failed test 'scripts/unnamed.sub.graph.pl runs without error'
BUILDSTDERR: #   at t/test.t line 40.
BUILDSTDERR: # Looks like you failed 40 tests of 43.
t/test.t ............... 
Dubious, test returned 40 (wstat 10240, 0x2800)
Failed 40/43 subtests 
t/test_more_methods.t .. ok
t/test_new.t ........... ok
Test Summary Report
-------------------
t/test.t             (Wstat: 10240 Tests: 43 Failed: 40)
  Failed tests:  2-41
  Non-zero exit status: 40
Files=3, Tests=63,  6 wallclock secs ( 0.03 usr  0.01 sys +  4.74 cusr  0.65
csys =  5.43 CPU)
Result: FAIL
BUILDSTDERR: Failed 1/3 test programs. 40/63 subtests failed.
BUILDSTDERR: make: *** [Makefile:994: test_dynamic] Error 255

   Add required BR for test scripts/ to run:

BuildRequires:  perl(File::Temp)
BuildRequires:  perl(Log::Handler)
BuildRequires:  perl(XML::Bare)



$ rpmlint perl-GraphViz2.spec
review-perl-GraphViz2/results/perl-GraphViz2-2.47-1.fc29.noarch.rpm
review-perl-GraphViz2/results/perl-GraphViz2-2.47-1.fc29.src.rpm 
perl-GraphViz2.noarch: W: spelling-error %description -l en_US pre -> per, ore,
pee
perl-GraphViz2.src: W: spelling-error %description -l en_US pre -> per, ore,
pee
2 packages and 1 specfiles checked; 0 errors, 2 warnings.


$ rpm -q -lv -p perl-GraphViz2-2.47-1.fc29.noarch.rpm
drwxr-xr-x    2 root    root                        0 juin 18 17:48
/usr/share/doc/perl-GraphViz2
-rw-r--r--    1 root    root                    33991 févr. 23 02:32
/usr/share/doc/perl-GraphViz2/Changelog.ini
-rw-r--r--    1 root    root                    33228 févr. 23 00:29
/usr/share/doc/perl-GraphViz2/Changes
-rw-r--r--    1 root    root                     1343 déc. 20  2013
/usr/share/doc/perl-GraphViz2/README
drwxr-xr-x    2 root    root                        0 juin 18 17:48
/usr/share/licenses/perl-GraphViz2
-rw-r--r--    1 root    root                    20231 mai  3  2016
/usr/share/licenses/perl-GraphViz2/LICENSE
-rw-r--r--    1 root    root                    18651 juin 18 17:48
/usr/share/man/man3/GraphViz2.3pm.gz
-rw-r--r--    1 root    root                     1995 juin 18 17:48
/usr/share/man/man3/GraphViz2::Config.3pm.gz
-rw-r--r--    1 root    root                     4244 juin 18 17:48
/usr/share/man/man3/GraphViz2::DBI.3pm.gz
-rw-r--r--    1 root    root                     3800 juin 18 17:48
/usr/share/man/man3/GraphViz2::Data::Grapher.3pm.gz
-rw-r--r--    1 root    root                     2389 juin 18 17:48
/usr/share/man/man3/GraphViz2::Filer.3pm.gz
-rw-r--r--    1 root    root                     3436 juin 18 17:48
/usr/share/man/man3/GraphViz2::Parse::ISA.3pm.gz
-rw-r--r--    1 root    root                     3153 juin 18 17:48
/usr/share/man/man3/GraphViz2::Parse::RecDescent.3pm.gz
-rw-r--r--    1 root    root                     3008 juin 18 17:48
/usr/share/man/man3/GraphViz2::Parse::Regexp.3pm.gz
-rw-r--r--    1 root    root                     3419 juin 18 17:48
/usr/share/man/man3/GraphViz2::Parse::STT.3pm.gz
-rw-r--r--    1 root    root                     3033 juin 18 17:48
/usr/share/man/man3/GraphViz2::Parse::XML.3pm.gz
-rw-r--r--    1 root    root                     3033 juin 18 17:48
/usr/share/man/man3/GraphViz2::Parse::Yacc.3pm.gz
-rw-r--r--    1 root    root                     3032 juin 18 17:48
/usr/share/man/man3/GraphViz2::Parse::Yapp.3pm.gz
-rw-r--r--    1 root    root                     2515 juin 18 17:48
/usr/share/man/man3/GraphViz2::Utils.3pm.gz
drwxr-xr-x    2 root    root                        0 juin 18 17:48
/usr/share/perl5/vendor_perl/GraphViz2
-rw-r--r--    1 root    root                    79311 févr. 23 02:32
/usr/share/perl5/vendor_perl/GraphViz2.pm
-rw-r--r--    1 root    root                     3352 févr. 23 02:32
/usr/share/perl5/vendor_perl/GraphViz2/Config.pm
-rw-r--r--    1 root    root                    11490 févr. 23 02:32
/usr/share/perl5/vendor_perl/GraphViz2/DBI.pm
drwxr-xr-x    2 root    root                        0 juin 18 17:48
/usr/share/perl5/vendor_perl/GraphViz2/Data
-rw-r--r--    1 root    root                    12479 févr. 23 02:32
/usr/share/perl5/vendor_perl/GraphViz2/Data/Grapher.pm
-rw-r--r--    1 root    root                     4340 févr. 23 02:32
/usr/share/perl5/vendor_perl/GraphViz2/Filer.pm
drwxr-xr-x    2 root    root                        0 juin 18 17:48
/usr/share/perl5/vendor_perl/GraphViz2/Parse
-rw-r--r--    1 root    root                     7912 févr. 23 02:32
/usr/share/perl5/vendor_perl/GraphViz2/Parse/ISA.pm
-rw-r--r--    1 root    root                     6971 févr. 23 02:32
/usr/share/perl5/vendor_perl/GraphViz2/Parse/RecDescent.pm
-rw-r--r--    1 root    root                    10435 févr. 23 02:32
/usr/share/perl5/vendor_perl/GraphViz2/Parse/Regexp.pm
-rw-r--r--    1 root    root                     6608 févr. 23 02:32
/usr/share/perl5/vendor_perl/GraphViz2/Parse/STT.pm
-rw-r--r--    1 root    root                     5345 févr. 23 02:32
/usr/share/perl5/vendor_perl/GraphViz2/Parse/XML.pm
-rw-r--r--    1 root    root                     5826 févr. 23 02:32
/usr/share/perl5/vendor_perl/GraphViz2/Parse/Yacc.pm
-rw-r--r--    1 root    root                     5803 févr. 23 02:32
/usr/share/perl5/vendor_perl/GraphViz2/Parse/Yapp.pm
-rw-r--r--    1 root    root                     5393 févr. 23 02:32
/usr/share/perl5/vendor_perl/GraphViz2/Utils.pm
File permissions and layout are Ok.

$ rpm -q --requires -p perl-GraphViz2-2.47-1.fc29.noarch.rpm | sort -f | uniq
-c
      1 perl(:MODULE_COMPAT_5.26.2)
      1 perl(Algorithm::Dependency)
      1 perl(Algorithm::Dependency::Source::HoA)
      1 perl(Capture::Tiny)
      1 perl(Class::ISA)
      1 perl(Class::Load)
      1 perl(Config)
      1 perl(Config::Tiny)
      1 perl(Data::Section::Simple)
      1 perl(Date::Simple)
      1 perl(DBIx::Admin::TableInfo)
      1 perl(File::Basename)
      1 perl(File::HomeDir)
      1 perl(File::Slurp)
      1 perl(File::Spec)
      1 perl(File::Temp)
      1 perl(File::Which)
      1 perl(GraphViz2)
      1 perl(GraphViz2::Config)
      1 perl(GraphViz2::Filer)
      1 perl(HTML::Entities::Interpolate)
      1 perl(IPC::Run3)
      1 perl(Lingua::EN::PluralToSingular)
      1 perl(Moo)
      1 perl(Parse::RecDescent)
      1 perl(Scalar::Util)
      1 perl(Set::Array)
      1 perl(strict)
      1 perl(Text::Xslate)
      1 perl(Tree::DAG_Node)
      1 perl(Try::Tiny)
      1 perl(Types::Standard)
      1 perl(warnings)
      1 perl(XML::Tiny)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
File permissions and layout are Ok.

$ rpm -q --provides -p perl-GraphViz2-2.47-1.fc29.noarch.rpm
perl(GraphViz2::Config) = 2.47                                                  
perl(GraphViz2::DBI) = 2.47                                                     
perl(GraphViz2::Data::Grapher) = 2.47                                           
perl(GraphViz2::Filer) = 2.47                                                   
perl(GraphViz2::Parse::ISA) = 2.47                                              
perl(GraphViz2::Parse::RecDescent) = 2.47                                       
perl(GraphViz2::Parse::Regexp) = 2.47                                           
perl(GraphViz2::Parse::STT) = 2.47                                              
perl(GraphViz2::Parse::XML) = 2.47                                              
perl(GraphViz2::Parse::Yacc) = 2.47                                             
perl(GraphViz2::Parse::Yapp) = 2.47                                             
perl(GraphViz2::Utils) = 2.47                                                   
perl-GraphViz2 = 2.47-1.fc29
Binary provides are Ok.

Package builds in F29
(https://koji.fedoraproject.org/koji/taskinfo?taskID=27704981)
Ok

The package is in line with Fedora and Perl packaging guidelines.


Resolution: Package not approved. Please add the BR mentioned earlier in order
to build and run the tests correctly

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/AUTWLWNQD4NEY6HLHFTFCEB42PZ5SYFY/




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux