[Bug 1591910] Review Request: blis - BLAS-like Library Instantiation Software

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1591910



--- Comment #4 from Dave Love <dave.love@xxxxxxxxxxxxxxxx> ---
(In reply to Antonio Trande from comment #2)
> - Fedora default flags are never used.

I think there's a fixme in the spec.  It's not easy to insert them in the build
framework, and Pabst found some of them hurt performance for libxsmm, though I
don't know if that's connected with the JIT and/or the static parts, and it's
difficult to deal with this as they're different in different versions. (Binary
hardening is the least of one's worries for HPC security...)

> - Note these warnings:
> 
> BUILDSTDERR: DEPRECATION WARNING: python2 invoked with /usr/bin/python.
> BUILDSTDERR:     Use /usr/bin/python3 or /usr/bin/python2
> BUILDSTDERR:     /usr/bin/python will be removed or switched to Python 3 in
> the future.
> BUILDSTDERR:     If you cannot make the switch now, please follow
> instructions at
> https://fedoraproject.org/wiki/Changes/
> Avoid_usr_bin_python_in_RPM_Build#Quick_Opt-Out

Sigh.  Where does that come from?  I guess it's a rawhide thing which I can't
easily check due to rawhide mock not working under RHEL7.

> You can explicitly use Python2, but BLIS could be ready for using Python3 by
> now.

It works with python 2.7+.  It was just easiest to base the spec on 2.7.

> - You're using double installation commands, in %%build before and manually
> in %%install then. I guess you can install just one time by using
> LIBBLIS_NAME and  INSTALL_PREFIX/PREFIX variables.

That didn't work last I tried.  I'll see if something has changed, but it
doesn't seem a big deal.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/AFY2AYAM5V2PL3E3SKWXOU73EPLA2X64/




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux