https://bugzilla.redhat.com/show_bug.cgi?id=1591556 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Group: is not used in Fedora - BuildRequires: python-devel is deprecated. Use: BuildRequires: python2-devel - %package -n python2-macaroons should include the python provide: %{?python_provide:%python_provide python2-macaroons} - make %{?_smp_mflags} → %make_build - make install DESTDIR=%{buildroot} → %make_install - Instead of: %post -p /sbin/ldconfig %postun -p /sbin/ldconfig Use: %ldconfig_scriptlets See https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets#Upgrade.2Fcompatibility_impact - You must install the LICENSE file in %files: %files %license LICENSE %{_libdir}/%{name}.so.* - The Requires should include %{?_isa} %package devel Summary: Development libraries linking against libmacaroons Requires: %{name}%{?_isa} = %{version}-%{release} - Simplify Source/URL URL: https://github.com/rescrv/libmacaroons Source0: %url/archive/releases/%{version}/%{name}-%{version}.tar.gz - Add a comment above the patch to explain what it's for -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/NTTSYZYTTCJ7MCODWLVAQBWEP5LDUJ7D/
