https://bugzilla.redhat.com/show_bug.cgi?id=1590988 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Group: is not used in Fedora - Use %rpmmacrodir: mkdir -p %{buildroot}%{rpmmacrodir} mkdir -p %{buildroot}/usr/bin mkdir -p %{buildroot}/%{_datadir}/freight/examples install -m 0644 rpm_macros/macros.freight %{buildroot}%{rpmmacrodir} install -m 0755 scripts/freight-cmd %{buildroot}/usr/bin/ install -m 0644 examples/* %{buildroot}/%{_datadir}/freight/examples And in %files: %{rpmmacrodir}/macros.freight - Source URL is incorrect. Also use %global, not define: %global githash c72ed55774bebdb35b5530b1c4bf9ae3c1472aa7 Source0: %url/freight/archive/%{githash}/freight-%{githash}.tar.gz - Extraction dir is incorrect: %prep %autosetup -n %{name}-%{githash} - There is no upstream release set, so Version: should be 0: Version: 0 - Snapshot info must be prefixed by a Release number, here 0.1 since it's a developnental snapshot: Release: 0.1.20180613git%githash%{?dist} - %changelog must be corrected accordingly: * Wed Jun 13 2018 Neil Horman <nhorman@xxxxxxxxxxxxx> - 0-0.1.20180613gitc72ed55 - Remove the extraneous tabs after Name: freight and Requires: rpm rpm-build mock bash dnf -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/MRQLIM5OZTG4GYPCE6F3RPBT47CTCYND/
