https://bugzilla.redhat.com/show_bug.cgi?id=1575601 --- Comment #8 from Tim Flink <tflink@xxxxxxxxxx> --- Overall, it looks pretty good but I found a few small concerns. 1. The license declaration in the spec file does not match the code packaged. Some of the packaged code is GPLv2, some of it is GPLv2+. If the declaration is changed to "GPLv2 and GPLv2+", that would be an acceptable solution. There is also no LICENSE file included upstream which would be preferred instead of just having license headers in most of the individual files. 2. I'm a little unclear on how these libraries are called, should the shell files be executable? 3. Requires issues? I'm going back and forth on this one - the individiual libraries are not usable without unlisted dependencies (mongodb, httpd, openssl etc.) but including all of those as requires seems a bit heavyweight and given the use case of these libraries, I'm not sure how critical it is to have all of those dependencies made explicit. One option would be to make all of the individual libraries into subpackages (which would also solve the licensing issue) but 4. Mariadb55 has (unstated) requirements which cannot be resolved in any current Fedora release. 5. The source URL is not valid, I get a 404 when I try to download beaker-libraries-0.2 I'll attach the review checklist to this bug but 1-4 will need to be resolved through fixing/discussion and 5 is a SHOULD have that I suspect is not intentional. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/SYIMBZEL2P4KLD7TNP73D7FDBEGEZLV6/
