[Bug 1591111] Review Request: perl-Hash-AutoHash - Object-oriented access to real and tied hashes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1591111

Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are almost ok
FIX: Please remove duplicity from build-requires
    - List::MoreUtils
    - Scalar::Util

$ rpm -qp --requires perl-Hash-AutoHash-1.17-1.fc29.noarch.rpm | sort | uniq -c
      1 perl(Carp) >= 1.2
      1 perl(List::MoreUtils) >= 0.33
      1 perl(:MODULE_COMPAT_5.26.2)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(Tie::Hash) >= 1.04
      1 perl(Tie::ToObject) >= 0.03
      1 perl(vars)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Hash-AutoHash-1.17-1.fc29.noarch.rpm | sort | uniq -c
      1 perl(Hash::AutoHash) = 1.17
      1 perl-Hash-AutoHash = 1.17-1.fc29
      1 perl(Hash::AutoHash::alias)
      1 perl(Hash::AutoHash::helper)
Binary provides are Ok.

$ rpmlint ./perl-Hash-AutoHash*
perl-Hash-AutoHash.noarch: W: spelling-error %description -l en_US AsObject ->
As Object, As-object, Object
perl-Hash-AutoHash.noarch: W: spelling-error %description -l en_US Inflator ->
Inflation, Infiltrator, Inhalator
perl-Hash-AutoHash.noarch: W: spelling-error %description -l en_US OpenStruct
-> Reconstruct, Construct
perl-Hash-AutoHash.noarch: W: spelling-error %description -l en_US AutoAccessor
-> Accessorize
perl-Hash-AutoHash.src: W: spelling-error %description -l en_US AsObject -> As
Object, As-object, Object
perl-Hash-AutoHash.src: W: spelling-error %description -l en_US Inflator ->
Inflation, Infiltrator, Inhalator
perl-Hash-AutoHash.src: W: spelling-error %description -l en_US OpenStruct ->
Reconstruct, Construct
perl-Hash-AutoHash.src: W: spelling-error %description -l en_US AutoAccessor ->
Accessorize
2 packages and 1 specfiles checked; 0 errors, 8 warnings.
Rpmlint is ok

Please correct 'FIX' issue.

The package looks good.
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/SV6W7ZV4CWJ6HLQTKVHKGTO7JKNQB7RA/




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux