https://bugzilla.redhat.com/show_bug.cgi?id=1590650 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Group: is not used in Fedora - make %{?_smp_mflags} → %make…build - make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p' → %make_install - Appdata files should now be install in /usr/share/metainfo instead of /usr/share/appdata See: https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html and: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html mkdir -p $RPM_BUILD_ROOT%{_metainfodir} cat > $RPM_BUILD_ROOT%{_metainfodir}/input-pad.appdata.xml <<EOF And in %files: %{_metainfodir}/*.appdata.xml - The appdata file need to be validated: %check desktop-file-validate \ $RPM_BUILD_ROOT%{_datadir}/applications/ibus-setup-input-pad.desktop appstream-util validate-relax --nonet $RPM_BUILD_ROOT%{_metainfodir}/*.appdata.xml - The license file must be installed with %license, not %doc: %files -f %{name}.lang %doc AUTHORS README %license COPYING - The license seems to be LGPLv2+ not GPLv2+: https://github.com/fujiwarat/input-pad/blob/f4fd523a5a5e01422b113e4e194f82ed7d801b07/COPYING -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/CGULPCXKO4H6E2VN5V5TOHB6GLF5YN3G/
