[Bug 1589633] Review Request: cocoalib - C++ library for computations in commutative algebra

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1589633



--- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> ---
(In reply to Robert-André Mauchin from comment #1)
>  - I don't think %{?_isa} is needed there:
> 
> Requires:       boost-devel%{?_isa}
> Requires:       gmp-devel%{?_isa}
> Requires:       gsl-devel%{?_isa}
> Requires:       libgfan-devel%{?_isa}

It is.  See
https://fedoraproject.org/wiki/Packaging:Guidelines#Architecture-specific_Dependencies.

>  - The -doc subpackage should be noarch

Good catch.  Fixed.

>  - cocoalib-doc.x86_64: E: incorrect-fsf-address
> /usr/share/licenses/cocoalib-doc/COPYING
> 
>    Notify upstream béout the incorrect address.

Yes, and I will also notify upstream about all of the patches I had to add,
just as soon as I figure out how to work upstream's bug tracker....

New URLs:
Spec URL: https://jjames.fedorapeople.org/cocoalib/cocoalib.spec
SRPM URL:
https://jjames.fedorapeople.org/cocoalib/cocoalib-0.99563-2.fc29.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/ZOLCW6FIBCKZ25F4GBLRC75JBMYHMT7M/




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux