https://bugzilla.redhat.com/show_bug.cgi?id=1368855 Michal Ambroz <rebus@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo? | --- Comment #33 from Michal Ambroz <rebus@xxxxxxxxx> --- Hello Anton, thanks for the offer. The situation seems indeed bit more difficult for me as packager to solve alone. Most of the patchable changes I was already able to push upstream to you guys. What remains are probably things which work well for you and are not politically correct for Fedora. You as Radare authors want it to make it as simple as possible for the users to download and compile from github ... which means some things are already bundled in to make it easy. I do not blame you for that. The paradigm of Fedora is to have everything as modular as possible - so if there is library for regular expressions, it should be in the system only once as a library package and all other application should be only dynamically linking to it. As long as the API is the same, it should be possible to independently patch and update single library. Here are notes from the spec file on what has been already removed: Removed from the final package because of the presence of minified JS and absence of the source JS - this should be packaged with radare2-webui shlr/www/m - Apache-2.0 shlr/www/enyo/vendors/jquery-ui.min.js - GPL + MIT shlr/www/enyo/vendors/jquery.layout-latest.min.js - GPL + MIT shlr/www/enyo/vendors/jquery.scrollTo.min.js - MIT shlr/www/enyo/vendors/lodash.min.js - lodash license shlr/www/enyo/vendors/joint.* - Mozilla MPL 2.0 shlr/www/enyo/vendors/jquery.min.js - Aplache License version 2.0 shlr/www/p/vendors/jquery* - GPL + MIT shlr/www/p/vendors/dagre*|graphlib* - 3 clause BSD shlr/www/p/vendors/jquery.onoff.min.js - MIT Some embedded libraries I was able to identify sofar: shlr/grub/grubfs.c - LGPL shlr/java - Apache 2.0 shlr/sdb/src - MIT shlr/spp - MIT shlr/squashfs/src - GPLv2+ shlr/tcc - LGPLv2+ shlr/udis86 - 2 clause BSD shlr/wind - LGPL v3+ shlr/spp - MIT shlr/zip/zlib - 3 clause BSD (system installed sared zlib is used instead) regular expressions library from BSD js0n library lz4 binutils vavrdisasm Sometimes it is not really clear how the library got to radare and what are the modifications to its code comparing to the upstream. For some of these it would be possible to use some dynamic library - like for the regular expressions or json. Personally I do not think there is much of things which shuold stand in a way to radare2 to be accepted as a package for Fedora, but of course I am probably biased as someone who already spent so much time with packaging and maintaining it for Fedora. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/SGZOE4TMLFFXXBHS7GZOGDEXCX33NZIT/
