https://bugzilla.redhat.com/show_bug.cgi?id=1586199 --- Comment #4 from Pavel Valena <pvalena@xxxxxxxxxx> --- (In reply to Jun Aruga from comment #1) > > #-devel > > # BuildRequires: rubygem(posix-spawn) > > Why does the only gem: posix-spawn for development is kept as commented line? > While the other gems guard are removed. Sorry, I forgot to remove those as well. > 2. > > > # Test failing with: > > # expected: "mogrify", got: nil > > sed -i '/^ it "assigns :mogrify by default" do$/,/ end/ s/^/#/g' \ > > spec/lib/mini_magick/configuration_spec.rb > > Seeing the source code, this failure happens when mogrify command > (ImageMagick package) is not installed. As you are setting ImageMagick as a > build dependency, you can remove this sed command line, right? You're right. I don't know why I did add the `sed`. Removed. > But after removing the line, you will face a different test failure of > ImageMagick unique tests. No, that failure is unrelated, the tests suceed, see bellow. > > ``` > Failures: > > 1) With ImageMagick MiniMagick::Image#details returns a hash of verbose > information > Failure/Error: expect(subject.details["Channel depth"]["Red"]).to eq > "8-bit" > > expected: "8-bit" > got: nil > > (compared using ==) > # ./spec/lib/mini_magick/image_spec.rb:423:in `block (5 levels) in <top > (required)>' > ``` This is actually fixed by Patch0. https://github.com/minimagick/minimagick/pull/454/ -- I've updated the srpm and .spec file in Description. New Scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=27475124 Thanks for finding those issues! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/HFK2JDGGNFNDVG5JQ5VVSAZDAHFNBYQP/
