https://bugzilla.redhat.com/show_bug.cgi?id=1585365 --- Comment #5 from Eamon Walsh <ewalsh@xxxxxxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD 3-clause "New" or "Revised" License", "Unknown or generated". 137 files have unknown license. Detailed output of licensecheck in /home/user/1585365-miniupnpd/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in miniupnpd-debuginfo , miniupnpd-debugsource [x]: Package functions as described. NOTE: verified that the daemon starts with systemctl after setting a listening_ip and ext_ifname in the configuration file [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. NOTE: the upstream home page does have a French version. The description and summary text do not appear to come from that page however. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. NOTE: no test target in upstream Makefile [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: miniupnpd-2.1-1.fc29.x86_64.rpm miniupnpd-debuginfo-2.1-1.fc29.x86_64.rpm miniupnpd-debugsource-2.1-1.fc29.x86_64.rpm miniupnpd-2.1-1.fc29.src.rpm miniupnpd.x86_64: W: spelling-error %description -l en_US UPnP -> Upon miniupnpd.x86_64: W: install-file-in-docs /usr/share/doc/miniupnpd/INSTALL NOTE: there are configuration instructions in INSTALL miniupnpd.src: W: spelling-error %description -l en_US UPnP -> Upon miniupnpd.src: W: strange-permission miniupnpd.service 640 NOTE: adjust "upstream" permission on the service file 4 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (debuginfo) ------------------- Checking: miniupnpd-debuginfo-2.1-1.fc29.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- miniupnpd.x86_64: W: spelling-error %description -l en_US UPnP -> Upon miniupnpd.x86_64: W: install-file-in-docs /usr/share/doc/miniupnpd/INSTALL 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Requires -------- miniupnpd (rpmlib, GLIBC filtered): /bin/sh config(miniupnpd) libc.so.6()(64bit) libip4tc.so.0()(64bit) libip6tc.so.0()(64bit) libuuid.so.1()(64bit) libuuid.so.1(UUID_1.0)(64bit) rtld(GNU_HASH) miniupnpd-debugsource (rpmlib, GLIBC filtered): miniupnpd-debuginfo (rpmlib, GLIBC filtered): Provides -------- miniupnpd: config(miniupnpd) miniupnpd miniupnpd(x86-64) miniupnpd-debugsource: miniupnpd-debugsource miniupnpd-debugsource(x86-64) miniupnpd-debuginfo: debuginfo(build-id) miniupnpd-debuginfo miniupnpd-debuginfo(x86-64) Source checksums ---------------- http://miniupnp.free.fr/files/miniupnpd-2.1.tar.gz : CHECKSUM(SHA256) this package : 950894779661197fe093855fda29a728f434b5756eb4fa6cb5f7b9bff7ffe0c1 CHECKSUM(SHA256) upstream package : 950894779661197fe093855fda29a728f434b5756eb4fa6cb5f7b9bff7ffe0c1 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1585365 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/7FPJD63V76FXGROOED3BVCYX3KUK6VBR/
