https://bugzilla.redhat.com/show_bug.cgi?id=1585365 Eamon Walsh <ewalsh@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ewalsh@xxxxxxxxxxxxxxxxx --- Comment #2 from Eamon Walsh <ewalsh@xxxxxxxxxxxxxxxxx> --- In the service unit file: ip6tables_init.sh and ip6tables_removeall.sh are not executed, add ExecStartPre and ExecStopPost lines for them. In the service unit file: -After=network.target network-online.target +After=network-online.target In the service unit file, suggest: -PIDFile=/run/miniupnpd.pid +PIDFile=/var/run/miniupnpd.pid since that's where the daemon thinks it is. Alternately, suggest passing "-P /run/miniupnpd.pid" to the daemon. In the service unit file, suggest: +Documentation: http://miniupnp.free.fr/ In the preamble: https://fedoraproject.org/wiki/Packaging:Scriptlets#Systemd wants %{?systemd_requires} when the systemd scriptlets are used. In %build: -make %{?_smp_mflags} -f Makefile.linux config.h #Enable IPv6/IGDv2 support -sed -i 's/\/*#define ENABLE_IPV6*\//#define ENABLE_IPV6/' config.h -sed -i 's/\/*#define IGD_V2*\//#define IGD_V2/' config.h +export CONFIG_OPTIONS="--ipv6 --igd2" (see Makefile.linux line 8) Also, the sed lines don't work as intended, the asterisks are not escaped In %build, suggest: -export CFLAGS="$RPM_OPT_FLAGS" +export CFLAGS="%{optflags}" based on https://pagure.io/package-cleanup-service "Style Guildelines" (6th bullet) In %install, suggest: -export STRIP="true" +export STRIP=/bin/true In %install, suggest: -mkdir -p %{buildroot}%{_unitdir} -cp -p %{SOURCE1} %{buildroot}%{_unitdir}/%{name}.service -chmod 644 %{buildroot}%{_unitdir}/%{name}.service +install -Dpm 644 %{SOURCE1} %{buildroot}%{_unitdir}/%{name}.service The INSTALL file does contain configuration instructions and probably should remain as a documentation file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/PO7RO3CDK3LKKCYZGN74NSLU5DIV6T2O/
