[Bug 1389404] Review Request: python-flask-pymongo - PyMongo support for Flask applications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1389404

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebob.m@xxxxxxxxx



--- Comment #6 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
 - Use BuildRequires:  python3-sphinx, not python-sphinx

 - Download the LICENSE file and install it:

Source1:       
https://raw.githubusercontent.com/dcrosta/flask-pymongo/master/LICENSE

   And:

%prep
%autosetup -n %{pypi_name}-%{version}
rm -rf %{pypi_name}.egg-info

cp %{S:1} .

   Then install it in %files:

%files -n python2-flask-pymongo
%license LICENSE
%doc README.md
%{python2_sitelib}/flask_pymongo
%{python2_sitelib}/Flask_PyMongo-%{version}-py*egg-info

%files -n python3-flask-pymongo
%license LICENSE
%doc README.md
%{python3_sitelib}/flask_pymongo
%{python3_sitelib}/Flask_PyMongo-%{version}-py*egg-info

%files -n python-flask-pymongo-doc
%license docs/_themes/LICENSE
%doc html 

 - Bump to 0.5.2

 - Generate the docs with:

# generate html docs 
PYTHONPATH=${PWD} sphinx-build-3 docs html
# remove the sphinx-build leftovers
rm -rf html/.{doctrees,buildinfo}

 - Add the required BR to generate the docs:

BuildRequires:  python2dist(flask) >= 0.8
BuildRequires:  python2dist(pymongo) >= 2.5
BuildRequires:  python2-pymongo-gridfs

BuildRequires:  python3dist(flask) >= 0.8
BuildRequires:  python3dist(pymongo) >= 2.5
BuildRequires:  python3-pymongo-gridfs

 - Not useful:

rm -rf %{python2_sitelib}/tests

 - The tests are not included with the Pypi anchive, remove:

%check
%{__python2} setup.py test
%{__python3} setup.py test

 - You could use the new python2dist/python3dist macros:

BuildRequires:  python2-devel
BuildRequires:  python2dist(setuptools)
BuildRequires:  python2dist(flask) >= 0.8
BuildRequires:  python2dist(pymongo) >= 2.5
BuildRequires:  python2-pymongo-gridfs

BuildRequires:  python3-devel
BuildRequires:  python3dist(setuptools)
BuildRequires:  python3dist(sphinx)
BuildRequires:  python3dist(flask) >= 0.8
BuildRequires:  python3dist(pymongo) >= 2.5
BuildRequires:  python3-pymongo-gridfs


   And:

%package -n     python2-flask-pymongo
Summary:        %{summary}
%{?python_provide:%python_provide python2-flask-pymongo}

Requires:       python2dist(flask) >= 0.8
Requires:       python2dist(pymongo) >= 2.5

   And:

%package -n     python3-flask-pymongo
Summary:        %{summary}
%{?python_provide:%python_provide python3-flask-pymongo}

Requires:       python3dist(flask) >= 0.8
Requires:       python3dist(pymongo) >= 2.5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/TFBHHPYFD2EDA6EVEXA35OV4O24G5FIX/




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux