https://bugzilla.redhat.com/show_bug.cgi?id=1571742 --- Comment #5 from Daniel J. R. May <daniel.may@xxxxxxxxxxxxxxx> --- (In reply to Per Bothner from comment #2) > Some preliminary informal comments, based on just the GitHub project. > These are my personal opinions/suggestions as a Fedora user, not a Fedora > packing expert. First of all thank you so much for taking the time to look at this & sorry for taking so long to reply - I have been away for the last couple of weeks. > * I think you need to make a case for why this should be in Fedora. It > would be helpful if you linked to some web-page that actually uses the > library - i.e. some real-life non-trivial web-page (with non-trivial > styling). Perhaps documentation or the home page for some other Fedora > package (or proposed package). I think you are absolutely correct! As it stands this project shows a little promise but it is not mature enough yet. On reflection, my desire to submit it to Fedora must have been a flash of middle-aged over-exuberance! I'm rather glad to see that I'm still capable of a bit over-exuberance! ;-) However, I think the correct thing to do is withdraw this Fedora submission and go again when/if the software is more mature, fully-featured, documented and with real-life non-trivial examples of use in the wild. It current existence on github and COPR are appropriate for now. > * How does your navigator deal with multiple pages? It seems it can only be > useful for navigating a single-page document. This limits its usefulness. > For comparison, I wrote a side-bar navigator for Kawa that handles > navigation both between and within pages. For example try: > https://www.gnu.org/software/kawa/Strings.html#Immutable-String-Constructors > . It might be useful to combine your logic for watching scrolling into my > side-bar navigator. Correct. As it stands it is a one-page only thing. Thank you for the links I will have a look into your suggestion. > * Using the GPL license for a JavaScript library means (I believe) that all > of the JavaScript on a web page has to be released under the GPL. This may > be a concern for some people, and limit take-up - and possibly its > suitability for Fedora. I was unaware of this - a really good point! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/R4ZK5HJPU7R46VA6YAGNN532BVUETGYF/