Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Etoys - Squeak-based learning environment for OLPC https://bugzilla.redhat.com/show_bug.cgi?id=247984 opensource@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |opensource@xxxxxxxxx ------- Additional Comments From opensource@xxxxxxxxx 2007-09-08 08:30 EST ------- Another issues: - provide a full URL in Source0 to get the tarball or include a comment how to generate the tarball - do not use /usr but %{_prefix} - %files needs a defattr line - use %{_libdir} and %{_datadir} in %files - is ROOT=%{buildroot} in %build really needed? - consider using disttag Please read: http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/RPMMacros (it's about %{_libdir} and other macros) http://fedoraproject.org/wiki/Packaging/ReviewGuidelines (defattr) http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-beca3bf84972f19a384cc2e5091ed47c2b3cebc7 (disttag) http://fedoraproject.org/wiki/Packaging/SourceURL (about the URL in Source0) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review