https://bugzilla.redhat.com/show_bug.cgi?id=1583023 --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Suggestions: 1) You have added common_desc macro but not used it anywhere. Also, I don't think you need it as this is not generating more than one subpackage. 2) You can use %autosetup macro instead of %setup as %autosetup -n Shobhika-%{version} 3) You can also add Appstream metainfo file for font. So if you have that as Source2 in spec file then you can add it as # Add AppStream metadata file install -Dm 0644 -p %{SOURCE2} \ %{buildroot}%{_datadir}/metainfo/%{fontname}.metainfo.xml %check appstream-util validate-relax --nonet \ %{buildroot}%{_datadir}/metainfo/%{fontname}.metainfo.xml then add this file entry to %_font_pkg macro of main package. 4) When you will update spec file, increase release count as 2 and add related changelog entry and submit new SPEC and SRPM urls for further review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/SXPX6JAR4VRC4XSJVRBB4M4AQBBIFRK3/
