Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: netpipe - A network performance measurement tool https://bugzilla.redhat.com/show_bug.cgi?id=281281 opensource@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |opensource@xxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From opensource@xxxxxxxxx 2007-09-08 03:21 EST ------- - naming: ok (debian also uses a lowercase name) - rpmlint: ok (silent) - source: ok cc458a9154f6b8c6da9fae16627beec4 NetPIPE-3.7.1.tar.gz cc458a9154f6b8c6da9fae16627beec4 NetPIPE-3.7.1.tar.gz.1 - BuildRoot: ok - Package compiles in koji for all supported archs - License: NEEDSWORK You use GPLv2+, but I cannot find any information on the version of the license, the header in some source files only mention GPL, but no version and so does README. Also no license text is included. These files do not contain any license header, but some contain an author: shmem.c MP_memcpy.c mpi2.c gpshmem.c gm.c armci.c Would you please ask upstream to update the license header (and the manpage and README) to a specific GPL Version, add a license header to the mentioned files and include the license text in the tarball? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review