https://bugzilla.redhat.com/show_bug.cgi?id=1582276 --- Comment #2 from Dick Marinus <dick@xxxxxxx> --- I've compared your specfile to a specfile generated by pyp2rpm-3.3.2 and found the following differences: 1. https://pypi.io instead of https://files.pythonhosted.org (I don't know which is better) 2. Summary: %{summary} is used in the subpackages instead of duplicating the same text 3. Instead of using Requires: python2-<<pypiname>> the python2dist(<<pypiname>>) macro (?) is used (I don't know what's better) 4. You're using %{sname} in: %{python2_sitelib}/%{sname} (I think you should fix this) 5. playbooks/README.md isn't packaged Besides this, I think it might be a good idea to deduplicate the %descriptions by using a macro: %global _description\ distroinfo is a python module for parsing, validating and querying\ distribution/packaging metadata stored in human readable and reviewable\ text/YAML files.\ \ distroinfo is a generic (re)implementation of rdoinfo parser which proved\ well suited for the task of interfacing with distribution metadata in a human\ friendly way. If you consider code reviews human friendly, that is.\ Which can be used as: %description %_description etc. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/ECX4OSYDEFVVWXYSCMO43U7QXPXTN2QW/
