https://bugzilla.redhat.com/show_bug.cgi?id=1581865 Kalev Lember <klember@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |klember@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |klember@xxxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Kalev Lember <klember@xxxxxxxxxx> --- Fedora review flatpak-module-tools-0.2-1.fc27.src.rpm 2018-05-24 $ rpmlint flatpak-module-tools-0.2-1.fc27.src.rpm \ flatpak-module-tools flatpak-module-tools.src: W: spelling-error Summary(en_US) runtimes -> run times, run-times, centimes flatpak-module-tools.src: W: spelling-error %description -l en_US runtimes -> run times, run-times, centimes flatpak-module-tools.noarch: E: explicit-lib-dependency libmodulemd flatpak-module-tools.noarch: W: spelling-error Summary(en_US) runtimes -> run times, run-times, centimes flatpak-module-tools.noarch: W: spelling-error %description -l en_US runtimes -> run times, run-times, centimes flatpak-module-tools.noarch: W: no-manual-page-for-binary flatpak-module 2 packages and 0 specfiles checked; 1 errors, 5 warnings. + OK ! needs attention + rpmlint warnings are harmless and can be ignored + The package is named according to Fedora packaging guidelines + The spec file name matches the base package name. + The package meets the Packaging Guidelines + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The license field in the spec file matches the actual license + The license text (LICENSE) is included in %license + Spec file is written in American English + Spec file is legible + Upstream sources match the sources in the srpm SHA512 (flatpak-module-tools-0.2.tar.gz) = 9481ee9c0f6d10acbf4bc2dec9663e3b980c0e051849a154aaab92be847458e63532800ebd66e6adb26fd8f188f235fa1e85e671d4f9432728418ad0153ed34c SHA512 (Download/flatpak-module-tools-0.2.tar.gz) = 9481ee9c0f6d10acbf4bc2dec9663e3b980c0e051849a154aaab92be847458e63532800ebd66e6adb26fd8f188f235fa1e85e671d4f9432728418ad0153ed34c + Package builds in koji n/a ExcludeArch bugs filed + BuildRequires look sane n/a locale handling n/a ldconfig in %post and %postun + Package does not bundle copies of system libraries n/a Package isn't relocatable + Package owns all the directories it creates + No duplicate files in %files + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect the runtime of application n/a Static libraries should be in -static n/a Development files should be in -devel n/a -devel must require the fully versioned base n/a Packages should not contain libtool .la files n/a Proper .desktop file handling + Doesn't own files or directories already owned by other packages + Filenames are valid UTF-8 Looks nice and clean. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/G2DQ7TB6PCRQNRBLUDOHYHALIFP3V4YM/
