Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: classads - a powerful and flexible, semi-structured representation of data https://bugzilla.redhat.com/show_bug.cgi?id=253249 nsantos@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nsantos@xxxxxxxxxx ------- Additional Comments From nsantos@xxxxxxxxxx 2007-09-07 14:54 EST ------- I've done a review of the SRPM provided, here are some comments: - tarfile matches upstream with the following md5 sum: $ md5sum classads-1.0rc2.tar.gz d3e08a8706b0ad405048192d5f049d28 classads-1.0rc2.tar.gz - managed to build rpms for i386: $ sudo rpmbuild -ba classads.spec error: Failed build dependencies: pcre-devel is needed by classads-1.0-0.1.rc2.i386 $ rpm -qa|grep pcre pcre-6.6-1.1 $ sudo rpmbuild -ba classads.spec --nodeps [...] Wrote: /usr/src/redhat/SRPMS/classads-1.0-0.1.rc2.src.rpm Wrote: /usr/src/redhat/RPMS/i386/classads-1.0-0.1.rc2.i386.rpm Wrote: /usr/src/redhat/RPMS/i386/classads-devel-1.0-0.1.rc2.i386.rpm Wrote: /usr/src/redhat/RPMS/i386/classads-static-1.0-0.1.rc2.i386.rpm Wrote: /usr/src/redhat/RPMS/i386/classads-debuginfo-1.0-0.1.rc2.i386.rpm Note: pcre was installed but pcre-devel was not; rpmbuild still completed successfully, so you may want to double check the need for pcre-devel. - rpmlint gives the following output: $ rpmlint /usr/src/redhat/SRPMS/classads-1.0-0.1.rc2.src.rpm W: classads invalid-license Condor Public License W: classads strange-permission classads.spec 0600 $ rpmlint /usr/src/redhat/RPMS/i386/classads-1.0-0.1.rc2.i386.rpm W: classads invalid-license Condor Public License $ rpmlint /usr/src/redhat/RPMS/i386/classads-devel-1.0-0.1.rc2.i386.rpm W: classads-devel invalid-license Condor Public License $ rpmlint /usr/src/redhat/RPMS/i386/classads-static-1.0-0.1.rc2.i386.rpm W: classads-static invalid-license Condor Public License $ rpmlint /usr/src/redhat/RPMS/i386/classads-debuginfo-1.0-0.1.rc2.i386.rpm W: classads-debuginfo invalid-license Condor Public License I understand the license issue is being worked on, the specfile permissions should be corrected. - checked provides of the built binary rpms: $ rpm -qp /usr/src/redhat/RPMS/i386/classads-1.0-0.1.rc2.i386.rpm --provides libclassad.so.0 libclassad_ns.so.0 classads = 1.0-0.1.rc2 $ rpm -qp /usr/src/redhat/RPMS/i386/classads-devel-1.0-0.1.rc2.i386.rpm --provides classads-devel = 1.0-0.1.rc2 $ rpm -qp /usr/src/redhat/RPMS/i386/classads-static-1.0-0.1.rc2.i386.rpm --provides classads-static = 1.0-0.1.rc2 $ rpm -qp /usr/src/redhat/RPMS/i386/classads-debuginfo-1.0-0.1.rc2.i386.rpm --provides libclassad.so.0.0.0.debug libclassad_ns.so.0.0.0.debug classads-debuginfo = 1.0-0.1.rc2 Seems the three remaining issues are dealing with the licensing, fixing the permissions on the specfile, and confirming or removing the pcre-devel dependency; everything else looks good. Nuno -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review