https://bugzilla.redhat.com/show_bug.cgi?id=1545479 --- Comment #5 from Tom Stellard <tstellar@xxxxxxxxxx> --- (In reply to Felix Schwarz from comment #4) > > I'm not going to push a ROCm 1.6 version of hcc into Fedora. I have updated > > the spec file locally to ROCm 1.7, but I would need to update rocm-runtime and > > libhsakmt in Fedora to ROCm 1.7, before I can it to Fedora. > > So this review request here is currently outdated (as you started to pacakge > ROCm 1.7)? Or is a package review pointless until ROCm works with mainline > kernel out of the box? (libhsakmt/thunk interface) > Yes, it is out-dated now. > > ROCm 1.8 hcc will probably not happen in Fedora because AMD have not released > > a special version of libhsakmt that works with the upstream kernel like they > > did for 1.6 and 1.7. > > Just out of curiosity/to get a more complete picture: This problem should be > solved once enough features are merged in amdkfd so the user space ROCm > stack works with a vanilla upstream kernel, right? Or is there some special > "secret sauce" which is unlikely to be upstreamed? > There are already enough features in upstream amdkfd, the issue now is getting a new thunk (hsakmt in Fedora) that is compatible with what is upstream. AMD has been publishing code for an upstream compatible thunk in this branch: https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface/commits/fxkamd/drm-next-wip. The current hsamkt Fedora was built from an early snapshot of this branch and the current HEAD is compatible with ROCm 1.7. Now that everything is upstream AMD is going to start working on making their 'official' thunk compatible with upstream, which I'm hoping will happen by ROCm 1.9. > Anyway, I don't want to turn this ticket into a personal support forum so > the more important question is: What should happen to this review request? > - Review it and push an (incomplete) ROCm 1.6 stack in Fedora? > - Close the request (because 1.7 will be submitted for merging at a later > time)? > - Keep it open because at some point in the future you submit a updated spec > for ROCM 1.7? Let's just keep it open for now in case I have to time to push the ROCm 1.7 packaging. The current 1.6 spec is old and has several bugs that I fixed with the 1.7 packaging. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/3S5PKA6534IBNOQQAS6ZD67EBNEAHUL2/
