https://bugzilla.redhat.com/show_bug.cgi?id=1580121 Artur Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx --- Comment #2 from Artur Iwicki <fedora@xxxxxxxxxx> --- >Group: Applications/Internet Drop this. https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections >License: LGPLv2+ and MIT+ Taking a short look at the repo, I think this should be "GPLv2 and LGPLv2+ and CC0". >URL: https://github.com/systemd/systemd-netlogd >Source0: https://github.com/systemd/systemd-netlogd/archive/v%{version}.tar.gz You can use %{URL} as part of Source0 to reduce repetition. >/usr/share/man/man1/systemd-netlogd.1.gz Do not specify ".gz" explicitly; use a wildcard that can match any compression method. https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages You should use macro forms of system directories: >/etc/systemd/... %{_sysconfdir}/systemd >/usr/share/man/man1/systemd-netlogd.1.gz %{_mandir}/man1/... https://fedoraproject.org/wiki/Packaging:RPMMacros Also, the spec link goes to a syntax-highlighted HTML rendering of the spec. Next time please provide a direct link (the "Raw" button in GitHub). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/3RXUPXR7QJUAXLHKUDWSPINQ2U5XMACE/
