[Bug 1578152] Review Request: perl-Minion - High performance job queue for the Perl programming language

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1578152



--- Comment #2 from Emmanuel Seyman <emmanuel@xxxxxxxxx> ---
(In reply to Jitka Plesnikova from comment #1)
>
> License of Minion is Artistic 2.0
> FIX: Please add also license 'MIT' and 'OFL', because Minion includes a few
>      files with different licenses. More info can be found in
>      Minion-9.03/lib/Minion.pm line 803 and in files bootstrap.css,
>      bootstrap.js, fontawesome.css, popper.js

Done.

> Summary is ok
> FIX: Just replace 'a high' with 'A high'

I went with 'High'. The article 'A' isn't of much use here.

I also corrected the spelling mistakes and changed the Source URL to metacpan
(since search.cpan.org is going the way of the dodo).

> Please correct all 'FIX' issues.

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Minion/perl-Minion.spec
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-Minion/perl-Minion-9.03-2.fc28.src.rpm

> Otherwise the package looks good.
> Approved

Thank you for the review, Jikta. Repo requested.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/WEEKVIHYCJFSYRYFFCZR3E2LQTLI434N/




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux