https://bugzilla.redhat.com/show_bug.cgi?id=1579416 --- Comment #1 from David Shea <dshea@xxxxxxxxxx> --- Created attachment 1438049 --> https://bugzilla.redhat.com/attachment.cgi?id=1438049&action=edit package review Ah jeez this review file is long, no wonder it took so long. My favorite part is the line saying that other packages own /lib/.build-id owned by this package, and then it lists the other packages, which is every package in Fedora. So good. But anyway good news most of it is garbage or complaining about things that don't apply to haskell. Here's the highlights: * The docs are too dang big. I think juhp is maybe working on something for that in cabal-rpm? I don't know, but The Guidelines are clear that we have to be as hostile as possible to developers if docs are over 1MB. https://src.fedoraproject.org/rpms/ghc-servant/blob/master/f/ghc-servant.spec is how I did it (split -devel.files into -devel-doc and -devel-nodoc in %install), and remove the -doc Provides from -devel * Nothing owns %{_libexecdir}/%{pkgver}. Just add that to %files. * We misspelled "included" in the desscription. That can wait for later since we can just blame upstream for now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/U4R6SDAHQ2ESEG5CEBLZZO437W5TTSN2/
