https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #31 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Hi, sorry for the delay. Please in the future use real links to the spec file and rpm. fedora-review than can download the srpm and spec automatically. In this case it should be something like: https://github.com/PerBothner/DomTerm/releases/download/1.0/domterm-1.0-1.fc27.src.rpm https://raw.githubusercontent.com/PerBothner/DomTerm/master/domterm.spec Source0 is wrong. It seems you didn't actually tag 1.0.2? > %global version ... This is not needed. Macro %version is automatically created from the Version field. > License: BSD1 The license tag should be one from https://fedoraproject.org/wiki/Licensing:Main#Software_License_List. I think you need License: BSD with advertising. But please consider switching to two-clause BSD, which is compatible with GPL. In %files, I'd suggest just useing %{_datadir}/domterm/help/ (without %dir). Unless you really want to list all files there. This will make version upgrades a bit easier. Apart from this package, can you please do the reviews mentioned in https://bugzilla.redhat.com/show_bug.cgi?id=1424890#c7. I'd like to wrap this up ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/YVRPZB3D6N36EAMB6FM6N3FD652IBC6S/
